Skip to content

fix(reactivity): ensure computed re-evaluates after dep cleanup#12021

Closed
jh-leong wants to merge 4 commits intovuejs:mainfrom
jh-leong:fix/12020
Closed

fix(reactivity): ensure computed re-evaluates after dep cleanup#12021
jh-leong wants to merge 4 commits intovuejs:mainfrom
jh-leong:fix/12020

Conversation

@jh-leong
Copy link
Member

close #12020

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 24, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12021

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12021

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12021

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12021

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12021

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12021

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12021

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12021

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12021

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12021

vue

pnpm add https://pkg.pr.new/vue@12021

commit: 10f846b

@github-actions
Copy link

github-actions bot commented Sep 24, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+56 B) 38.1 kB (+33 B) 34.2 kB (-2 B)
vue.global.prod.js 160 kB (+56 B) 58 kB (+32 B) 51.5 kB (-12 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.1 kB (+56 B) 18.9 kB (+34 B) 17.3 kB (+13 B)
createApp 55.6 kB (+56 B) 21.4 kB (+34 B) 19.5 kB (-8 B)
createSSRApp 59.7 kB (+56 B) 23.1 kB (+31 B) 21.1 kB (+84 B)
defineCustomElement 60.4 kB (+56 B) 23 kB (+28 B) 21 kB (+18 B)
overall 69.4 kB (+56 B) 26.5 kB (+30 B) 24.1 kB (+95 B)

@jh-leong
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Sep 24, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success failure
vuetify success success
vueuse success success
vue-simple-compiler success success

@samuelwei
Copy link

+1 This fixes a bug since Vue 3.5.7
My CI tests suddenly failed with Vue 3.5.7+ because the pinia getters were no longer computed

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: reactivity ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Sep 24, 2024
@jh-leong jh-leong changed the title fix(reactivity): reset computed version after dependency cleanup fix(reactivity): ensure computed re-evaluates after dep cleanup Sep 25, 2024
@jh-leong
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Sep 25, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success failure
vuetify success success
vueuse success success
vue-simple-compiler success success

@yyx990803 yyx990803 closed this in 6001e5c Sep 26, 2024
@jh-leong jh-leong deleted the fix/12020 branch September 26, 2024 09:00
abdullah-wn pushed a commit to Lazy-work/vue that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged. scope: reactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hooks not re-added after v-if optimization in options API

4 participants