fix(types): retain union type narrowing with defaults applied#12108
Merged
fix(types): retain union type narrowing with defaults applied#12108
Conversation
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/runtime-core
@vue/reactivity
@vue/runtime-dom
@vue/server-renderer
@vue/shared
@vue/compat
vue
commit: |
jh-leong
reviewed
Oct 4, 2024
jh-leong
approved these changes
Oct 4, 2024
|
Could you please check if it somehow helps with #12110 |
Member
Author
I think it is related to |
|
I'd like to cherry-pick both this and #12059 but I get conflicts with https://github.com/vuejs/core/pull/12059/files#diff-ddb3174016350dd4464764b4a1ba232d09ad1e75164d4a37758c759d019202e4 How would you solve it in the context of the other PR? |
1 task
Member
|
/ecosystem-ci run |
Contributor
|
📝 Ran ecosystem CI: Open
|
Member
|
I mistyped the issue number when merging 😓 |
|
I guess that #12059 needs to be rebased on top of this to fix the remaining issue, right? |
abdullah-wn
pushed a commit
to Lazy-work/vue
that referenced
this pull request
Jan 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #12106