feat(sfc): add defineEmits and deprecate defineEmit#3725
Merged
Conversation
Size report
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on vuejs/rfcs#243 and the 3 other repeated PRs. I'm proposing to deprecate
defineEmitin favour ofdefineEmitsas defined in the RFC and to match theemitsoption as well as the plural ofdefinePropsEven though the we are defining the
emittype of the context option insetup(props, { emit }), it seems more idiomatic to make it plural to matchdefineProps