fix(compiler): comment can cause vIf-related syntax errors#6843
Closed
Dunqing wants to merge 2 commits intovuejs:mainfrom
Closed
fix(compiler): comment can cause vIf-related syntax errors#6843Dunqing wants to merge 2 commits intovuejs:mainfrom
Dunqing wants to merge 2 commits intovuejs:mainfrom
Conversation
Member
|
Can you add some tests to it? Thanks |
Contributor
Author
|
This test is the same as this issue, so I don't need to add the same cases for the test. core/packages/compiler-core/__tests__/transforms/vIf.spec.ts Lines 652 to 664 in 35dc2bb |
antfu
approved these changes
Oct 12, 2022
Member
|
Thanks for the PR. We still need a separate test case for this to better document the problem, and we should not introduce test-only logic to fix a case. See dd3354c |
chrislone
pushed a commit
to chrislone/core
that referenced
this pull request
Feb 4, 2023
zhangzhonghe
pushed a commit
to zhangzhonghe/core
that referenced
this pull request
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: keep comments in production and have a comment between v-if and v-else, encounter
[vite:vue] v-else/v-else-if has no adjacent v-if or v-else-if.errorWhy is test work?
Since the following code works in the test, the comments can be skipped.
core/packages/compiler-core/src/transforms/vIf.ts
Lines 132 to 136 in 35dc2bb
Steps to reproduce
npm run build