Skip to content

$theme-default: using '.theme-default-content' to replace '.content' in 404 layout#1646

Merged
ulivz merged 1 commit intovuejs:masterfrom
ngocnv-0940:master
Jun 9, 2019
Merged

$theme-default: using '.theme-default-content' to replace '.content' in 404 layout#1646
ulivz merged 1 commit intovuejs:masterfrom
ngocnv-0940:master

Conversation

@ngocnv-0940
Copy link
Contributor

@ngocnv-0940 ngocnv-0940 commented Jun 9, 2019

Summary

$theme-default: using class '.theme-default-content' instead of '.content' in 404 layout

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

  • before

Screenshot from 2019-06-09 22-28-46

  • after

Screenshot from 2019-06-09 22-28-59

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ulivz ulivz merged commit f0d1344 into vuejs:master Jun 9, 2019
@vue-bot
Copy link

vue-bot commented Jun 9, 2019

Hey @ngocbnv-0940, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants