fix($theme-default): make arrow spacing consistent#1907
Merged
ulivz merged 1 commit intovuejs:masterfrom Oct 4, 2019
kleisauke:fix-arrow-spacing
Merged
fix($theme-default): make arrow spacing consistent#1907ulivz merged 1 commit intovuejs:masterfrom kleisauke:fix-arrow-spacing
ulivz merged 1 commit intovuejs:masterfrom
kleisauke:fix-arrow-spacing
Conversation
Minor regression of PR #1427.
kleisauke
referenced
this pull request
Oct 3, 2019
* refactor(default-theme): Extract PageEdit component and Extract PageNav component.
ulivz
approved these changes
Oct 4, 2019
|
Hey @kleisauke, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a minor UI regression of PR #1427, which I reported as an inline-comment here.
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Before (v1.1.0):
After (same as v1.0.4):
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: