Skip to content

Commit 71de2ab

Browse files
committed
Downgrade the C++ version to C++17 as the builtin protobuf-lite + MSVC have less support.
1 parent 4632778 commit 71de2ab

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ if(WIN32)
5050
set(SPM_ENABLE_SHARED OFF)
5151
endif()
5252

53-
set(CMAKE_CXX_STANDARD 20)
53+
set(CMAKE_CXX_STANDARD 17)
5454
set(CMAKE_CXX_STANDARD_REQUIRED ON)
5555

5656
if((CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND
@@ -98,8 +98,6 @@ endif()
9898

9999
if (MSVC)
100100
add_definitions("/wd4267 /wd4244 /wd4305 /Zc:strictStrings /utf-8")
101-
# TODO(taku): Update protobuf to deprecate C++17
102-
add_compile_definitions(_SILENCE_ALL_CXX20_DEPRECATION_WARNINGS)
103101
if (SPM_ENABLE_MSVC_MT_BUILD)
104102
string(REPLACE "/MD" "/MT" CMAKE_CXX_FLAGS_DEBUG ${CMAKE_CXX_FLAGS_DEBUG})
105103
string(REPLACE "/MD" "/MT" CMAKE_CXX_FLAGS_MINSIZEREL ${CMAKE_CXX_FLAGS_MINSIZEREL})

0 commit comments

Comments
 (0)