From 53f51a9db2cd9fdc615430050c32f55f30dd7a95 Mon Sep 17 00:00:00 2001 From: Justin Brooks Date: Tue, 22 Aug 2023 22:35:16 -0400 Subject: [PATCH 1/2] fix: Properly set namespace for deployments --- controllers/weightsandbiases_controller.go | 3 ++- pkg/helm/chart.go | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/controllers/weightsandbiases_controller.go b/controllers/weightsandbiases_controller.go index cf241a14..538a4136 100644 --- a/controllers/weightsandbiases_controller.go +++ b/controllers/weightsandbiases_controller.go @@ -169,11 +169,12 @@ func (r *WeightsAndBiasesReconciler) Reconcile(ctx context.Context, req ctrl.Req if err := specManager.SetActive(desiredSpec); err != nil { r.Recorder.Event(wandb, corev1.EventTypeNormal, "SetActiveFailed", "Failed to save active state") - log.Error(err, "Failed to save active sucessful spec.") + log.Error(err, "Failed to save active successful spec.") return ctrlqueue.DoNotRequeue() } log.Info("Successfully saved active spec") + r.Recorder.Event(wandb, corev1.EventTypeNormal, "Completed", "Completed reconcile successfully") statusManager.Set(status.Completed) return ctrlqueue.RequeueWithDelay(ctrlqueue.CheckForUpdatesFrequency) } diff --git a/pkg/helm/chart.go b/pkg/helm/chart.go index bb841831..d4bb7021 100644 --- a/pkg/helm/chart.go +++ b/pkg/helm/chart.go @@ -25,6 +25,7 @@ var ( // where to store the versions func InitConfig(namespace string) (*cli.EnvSettings, *action.Configuration, error) { settings := cli.New() + settings.SetNamespace(namespace) config := new(action.Configuration) err := config.Init( settings.RESTClientGetter(), From d764e40d13123a43c06691d9ac2f2ed59fa48510 Mon Sep 17 00:00:00 2001 From: semantic-release-bot Date: Wed, 23 Aug 2023 02:35:58 +0000 Subject: [PATCH 2/2] chore(release): version 1.8.4 [skip ci] ### [1.8.4](https://github.com/wandb/operator/compare/v1.8.3...v1.8.4) (2023-08-23) ### Bug Fixes * Properly set namespace for deployments ([53f51a9](https://github.com/wandb/operator/commit/53f51a9db2cd9fdc615430050c32f55f30dd7a95)) --- CHANGELOG.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d486b157..89e88241 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,13 @@ All notable changes to this project will be documented in this file. +### [1.8.4](https://github.com/wandb/operator/compare/v1.8.3...v1.8.4) (2023-08-23) + + +### Bug Fixes + +* Properly set namespace for deployments ([53f51a9](https://github.com/wandb/operator/commit/53f51a9db2cd9fdc615430050c32f55f30dd7a95)) + ### [1.8.3](https://github.com/wandb/operator/compare/v1.8.2...v1.8.3) (2023-08-23)