first request to findAll does not resolve correctly

[dagda1]

I am using the latest from master (revision 13)

I am finding that the first request to any resource returns 0 records on the first call to findAll, for example

App.Contact.find().then (contacts) ->
  console.log contacts.get('length')

What I am finding is that the console.log statement above will log 0 but if I then type:

App.Contact.find().get('length')

into the console after the page has refreshed and a call to findAll has been made, the length is as I would expect, i.e. greater than 0.

This happens for any resource, I have stepped through the code and the json is getting materialized into the models but for some reason, the record array is empty.

I have stepped through the code and it appears that the promise is resolving before didFIndAll is called.

I cannot create a fiddle for this as it is only happening with the rest adapter.

[sly7-7]

@dagda1 Actually, DS.Model.find() return a 'promistified' RecordArray whch promise is resolved when the recordarray is loaded (ie its isLoaded propery is true). The problem is that DS.Model.find() is loaded as soon as the array is created, as a consequence the promise is resolved.

In order to fix your problem (because I think you want to return a live array), something like this should work:

App.Contact.find({}).then(contacts) ->
   return App.Contact.all()

This way, under the hood, you are calling a findQuery, which is loaded when the backend returns the records, not at the array creation.

cc/ @tchak, I'd like you to confirm this though, to be sure I'm right.

[ahawkins]

@sly7-7 this sounds like the perfect amount of hax to be correct. This would not surprise me at all.

[dagda1]

That does indeed work.

[sly7-7]

Yeah, so I would say it's not an "issue" because this is the way it's intended to work. But this should definitely change. I really hope @tchak and @stefanpenner could work together in order to make ember-data and promises working great together.

[dagda1]

I think the current behaviour of find will be unexpected to most people. It was to me anyway.

[ahawkins]

Confirm. The current behavior makes no sense.

On Fri, May 31, 2013 at 11:08 PM, Paul notifications@github.com wrote:

I think the current behaviour of find will be unexpected to most people.
It was to me anyway.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1013#issuecomment-18771688
.

[sly7-7]

@dagda1 @ahawkins I agree with you, but as explained here #735 (comment) we have to define when should we consider the array as "loaded".
In ths specific case of resolving the promise for the findAll (not the all() one), perhaps we could resolve it when the isUpdating flag is set to false.

[shonsaoji]

I faced the same issue.

I am using ruby on rails with include_root_in_json set to true..
The response format for API /verticals is

{
verticals:[{
verticals: {id: 1, name: vertical_one},
verticals: {id: 2, name: vertical_two},
}]
};
To handle this I had to change the following -
line: 7081
method: extractMany
file: ember-data.js

var reference = this.extractRecordRepresentation(loader, type, objects[i]); // <-- changed this to pass objects[i][root] to the method.

That fixed it for me.

[towerhe]

@shonsaoji I think you should response:

{
  verticals: [{
    id: 1, name: "vertical_one"
  }, {
    id: 2, name: "vertical_two"
  }]
}

You could use active_model_serializers to serialize your models.

[tchak]

@dagda1 @ahawkins @sly7-7 what happens if you create a record on the client before calling find? And you know that RecordArray returned from find is the same that the one returned from all right?
Good news, I think I may have an idea :) You focussing on find, where what you want is a more flexible filter.
You may already accomplish almost what you want by calling :

App.Post.filter({}, Em.K);

The only part missing is isLoaded flag. I think it would not be unreasonable to set it to true only on adapter response in case filter is called with two arguments. Patch with a proposition is in progress :)

[tchak]

@dagda1 @ahawkins would you be happy with #1015 ?

App.Post.filter({}, Em.K).then(function() { console.log("Tada!"); });

[dagda1]

My concern would be that people new to ember (which we need to encourage more of) would not know what to make of:

App.Post.filter({}, Em.K)

Maybe we should give it some sugar in the form of a nicer name that delegates to this?

findAll would be my choice (joke) :)

[tchak]

@dagda1 People new to ember should not need it :)

[jaaksarv]

This is definitely a bug. Maybe not implementation bug (if it is intented to be so), but design bug. isLoaded should become true only when finished loading data from the server. If there is a need in Ember internal workings to observer when the "live array" becomes initialised then please implement a isArrayInitilised state for this. Or please at least add isReallyReallyLoaded state so we can build applications.

find({}) workaround to trigger findQuery is not a solution, but a hack. It does not work for example for FixtureAdapter.