Commit 3016b20
committed
WebDriverBrowser.stop() should only check the WebDriver server
Previously, we'd check any overridden `is_alive` method; thus we might
not stop the WebDriver server process if any part of the browser was
not still alive.
For example, if the SafariBrowser class had:
```
def is_alive(self):
return (
process_is_alive("Safari")
and process_is_alive("webinspectord")
and super().is_alive()
)
def stop(self, force=False):
terminate_process("Safari")
super().stop(force=force)
```
Then we would never terminate `safaridriver` in the superclass,
because we would've already have terminated Safari and thus the
browser would report itself as no longer alive, which seems like the
desired behaviour given it's no longer in a state to run tests.1 parent cc793b8 commit 3016b20
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
389 | 389 | | |
390 | 390 | | |
391 | 391 | | |
392 | | - | |
| 392 | + | |
393 | 393 | | |
394 | 394 | | |
395 | 395 | | |
| |||
398 | 398 | | |
399 | 399 | | |
400 | 400 | | |
401 | | - | |
| 401 | + | |
402 | 402 | | |
403 | 403 | | |
404 | 404 | | |
| |||
0 commit comments