Skip to content

Commit bd6b710

Browse files
jschweservo-wpt-sync
authored andcommitted
servoshell: Rename executable to servoshell.
This should help clarify the difference between servo the library / engine and servoshell the browser (demo). Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
1 parent ed2fbc2 commit bd6b710

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

tools/wpt/browser.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2315,7 +2315,7 @@ def install(self, dest=None, channel="nightly"):
23152315

23162316
resp = self._get(channel)
23172317
decompress(resp.raw, dest=dest)
2318-
path = which("servo", path=os.path.join(dest, "servo"))
2318+
path = which("servoshell", path=os.path.join(dest, "servo"))
23192319
st = os.stat(path)
23202320
os.chmod(path, st.st_mode | stat.S_IEXEC)
23212321
return path

tools/wpt/run.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -721,7 +721,7 @@ def setup_kwargs(self, kwargs):
721721
binary = self.browser.find_binary(self.venv.path, None)
722722

723723
if binary is None:
724-
raise WptrunError("Unable to find servo binary in PATH")
724+
raise WptrunError("Unable to find servoshell binary in PATH")
725725
kwargs["binary"] = binary
726726

727727

@@ -738,7 +738,7 @@ def setup_kwargs(self, kwargs):
738738
binary = self.browser.find_binary(self.venv.path, None)
739739

740740
if binary is None:
741-
raise WptrunError("Unable to find servo binary in PATH")
741+
raise WptrunError("Unable to find servoshell binary in PATH")
742742
kwargs["binary"] = binary
743743

744744

tools/wptrunner/wptrunner/browsers/servo_legacy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ def executor_browser(self):
9595

9696
class ServoLegacyWdspecBrowser(WebDriverBrowser):
9797
# TODO: could share an implemenation with servodriver.py, perhaps
98-
def __init__(self, logger, binary="servo", webdriver_binary="servo",
98+
def __init__(self, logger, binary="servoshell", webdriver_binary="servoshell",
9999
binary_args=None, webdriver_args=None, env=None, port=None,
100100
headless=None,
101101
**kwargs):

0 commit comments

Comments
 (0)