Commit fcfb8ff
authored
[wptrunner] Coerce script timeout to integer for non-wdspec tests (#58026)
https://crrev.com/c/7522226 seems to have caused Chrome on iOS results
to disappear from wpt.fyi because the final timeout is [fractional]:
```
webdriver.error.InvalidArgumentException: invalid argument (500): Timeouts must be non-negative integers
```
This can be replicated with the right `wpt run --timeout-multiplier`, so
avoid fractional timeouts in general. The spec for "Set Timeouts" isn't
clear on how they should be handled (w3c/webdriver#1949), but the de
facto behavior is to return "invalid argument".
Note that the WebDriver client can still send fractional timeouts to
test invalid values.
[fractional]: https://chromium-swarm.appspot.com/task?id=7673a57e106bad10&w=true1 parent 7a2bcbd commit fcfb8ff
1 file changed
+5
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
85 | 89 | | |
86 | 90 | | |
87 | 91 | | |
| |||
0 commit comments