ChildNode, ParentNode: Fix cases where nodes that were already connected and then inserted elsewhere did not have their disconnectedCallback called.

Author: bicknellr

src/Patch/Interface/ChildNode.js

@@ -21,8 +21,16 @@ export default function(internals, destination, builtIn) {
    * @param {...(!Node|string)} nodes
    */
   destination['before'] = function(...nodes) {
+    const connectedBefore = /** @type {!Array<!Node>} */ (nodes.filter(node => {
+      return node instanceof Node && Utilities.isConnected(node);
+    }));
+
     builtIn.before.apply(this, nodes);
 
+    for (const node of connectedBefore) {
+      internals.disconnectTree(node);
+    }
+
     if (Utilities.isConnected(this)) {
       for (const node of nodes) {
         if (node instanceof Element) {
@@ -36,8 +44,16 @@ export default function(internals, destination, builtIn) {
    * @param {...(!Node|string)} nodes
    */
   destination['after'] = function(...nodes) {
+    const connectedBefore = /** @type {!Array<!Node>} */ (nodes.filter(node => {
+      return node instanceof Node && Utilities.isConnected(node);
+    }));
+
     builtIn.after.apply(this, nodes);
 
+    for (const node of connectedBefore) {
+      internals.disconnectTree(node);
+    }
+
     if (Utilities.isConnected(this)) {
       for (const node of nodes) {
         if (node instanceof Element) {
@@ -51,10 +67,18 @@ export default function(internals, destination, builtIn) {
    * @param {...(!Node|string)} nodes
    */
   destination['replaceWith'] = function(...nodes) {
+    const connectedBefore = /** @type {!Array<!Node>} */ (nodes.filter(node => {
+      return node instanceof Node && Utilities.isConnected(node);
+    }));
+
     const wasConnected = Utilities.isConnected(this);
 
     builtIn.replaceWith.apply(this, nodes);
 
+    for (const node of connectedBefore) {
+      internals.disconnectTree(node);
+    }
+
     if (wasConnected) {
       internals.disconnectTree(this);
       for (const node of nodes) {

src/Patch/Interface/ParentNode.js

@@ -22,14 +22,21 @@ export default function(internals, destination, builtIn) {
    * @param {...(!Node|string)} nodes
    */
   destination['prepend'] = function(...nodes) {
+    const connectedBefore = /** @type {!Array<!Node>} */ (nodes.filter(node => {
+      return node instanceof Node && Utilities.isConnected(node);
+    }));
+
     builtIn.prepend.apply(this, nodes);
 
-    const connected = Utilities.isConnected(this);
-    if (connected) {
-      for (const node of nodes) {
-        if (!(node instanceof Element)) continue;
+    for (const node of connectedBefore) {
+      internals.disconnectTree(node);
+    }
 
-        internals.connectTree(node);
+    if (Utilities.isConnected(this)) {
+      for (const node of nodes) {
+        if (node instanceof Element) {
+          internals.connectTree(node);
+        }
       }
     }
   };
@@ -38,14 +45,21 @@ export default function(internals, destination, builtIn) {
    * @param {...(!Node|string)} nodes
    */
   destination['append'] = function(...nodes) {
+    const connectedBefore = /** @type {!Array<!Node>} */ (nodes.filter(node => {
+      return node instanceof Node && Utilities.isConnected(node);
+    }));
+
     builtIn.append.apply(this, nodes);
 
-    const connected = Utilities.isConnected(this);
-    if (connected) {
-      for (const node of nodes) {
-        if (!(node instanceof Element)) continue;
+    for (const node of connectedBefore) {
+      internals.disconnectTree(node);
+    }
 
-        internals.connectTree(node);
+    if (Utilities.isConnected(this)) {
+      for (const node of nodes) {
+        if (node instanceof Element) {
+          internals.connectTree(node);
+        }
       }
     }
   };