Introduce own exception for assertions - #222
Merged
Merged
Conversation
Ocramius
approved these changes
Nov 6, 2020
Ocramius
left a comment
Ocramius
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM, but we really need to put a nail on the coffin of exception overrides (still possible, really bad idea, and to be deprecated/removed).
Contributor
|
Hm.. Interesting. I was sure we already did this. |
Contributor
|
Could you please rebase this PR? |
andrew-demb
force-pushed
the
own-exception
branch
from
January 18, 2021 12:57
ac7fe5d to
6c9734f
Compare
Contributor
Author
|
Rebased. |
Contributor
|
Thank you. Im 👍 |
BackEndTea
approved these changes
Jan 18, 2021
Contributor
|
Thank you |
This was referenced Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May be helpful for catching only exceptions related to this package without the risk to catch another not related exceptions.
Ref #202