Skip to content

Add a note about static analysis - #235

Merged
Nyholm merged 4 commits into
webmozarts:masterfrom
staabm:patch-1
Feb 28, 2021
Merged

Add a note about static analysis#235
Nyholm merged 4 commits into
webmozarts:masterfrom
staabm:patch-1

Conversation

@staabm

@staabm staabm commented Jan 19, 2021

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread README.md Outdated

## Static analysis support

Where applicable assertion functions are annotated to support Psalms' [Assertion syntax](https://psalm.dev/docs/annotating_code/assertion_syntax/). A dedicated [PHPStan Plugin](https://github.com/phpstan/phpstan-webmozart-assert) is required for proper type support.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Two things:

  • Write Psalm's
  • Split this line after the word after 80 character length.

@staabm staabm Jan 19, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, adjusted (not accurately on 80 chars.. hope thats ok) - have no editor at hand atm.

@staabm

staabm commented Feb 26, 2021

Copy link
Copy Markdown
Contributor Author

ping @Nyholm

Comment thread README.md Outdated

@Nyholm Nyholm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants