updates based on feedback

Author: Matt

app/css/ui.css

@@ -149,11 +149,7 @@ body {
   visibility: hidden;
 }
 
-.ui-tabs-tab:hover .ui-icon-close
-{
-  visibility: visible;
-}
-
+.ui-state-active .ui-icon,
 .ui-tabs-tab:hover .ui-icon-close
 {
   visibility: visible;

app/js/Tab.js

@@ -26,8 +26,8 @@ class Tab {
    * @param {Element} container
    */
 
-  constructor(container, tabName) {
-     console.log(tabName)
+  constructor(container, tabName, filename) {
+
     this.tabName = tabName || " ";
     this.container = container
     this.container.html(defaultTab)
@@ -67,10 +67,13 @@ class Tab {
    * @param {Integer} tabId
    */
 
-  static generateTabHeaderTemplate(tabId, tabName) {
+  static generateTabHeaderTemplate(tabId, tabName, filename) {    
+    let tabMarkup = (filename === undefined) ? 
+      `<a href="#tab-${tabId}">${ tabId + " [no name]"}</a>` :
+      `<a href="#tab-${tabId}" title="${filename}">${ tabName }</a>` 
     return `
       <li data-tab="${tabId}">
-        <a href="#tab-${tabId}">${tabName || "Untitled-" + tabId }</a>
+        ${ tabMarkup }
         <span class="ui-icon ui-icon-close" role="presentation">Remove Tab</span>
       </li>
     `

app/js/Tabs.js

@@ -83,10 +83,10 @@ class Tabs {
    * @param {Integer} currsorPos The line to start the cursor on
    */
 
-  newTab(input, cursorPos, tabName) {
+  newTab(input, cursorPos, tabName, filename) {
 
     // Generate HTML
-    const tabEl = $(Tab.generateTabHeaderTemplate(this.totalTabsCreated, tabName))
+    const tabEl = $(Tab.generateTabHeaderTemplate(this.totalTabsCreated, tabName, filename))
     const contentEl = $(Tab.generateTabContentTemplate(this.totalTabsCreated))
 
     // Setup listener to remove tab
@@ -98,7 +98,7 @@ class Tabs {
     this.container.append(contentEl)
 
     // Create the new tab
-    const newTab = new Tab(contentEl, tabName)
+    const newTab = new Tab(contentEl, tabName, filename)
     newTab.setTheme(this.theme)
     this.tabs.push(newTab)
 

app/js/system/MainMenu.js

@@ -53,7 +53,7 @@ class MainMenu {
               }
               window.app = this.app
 
-              this.app.tabs.newTab(fs.readFileSync(filename, 'utf8'), 0, path.basename(filename) )             
+              this.app.tabs.newTab(fs.readFileSync(filename, 'utf8'), 0, path.basename(filename), filename )             
 
               this.updateMenu()
             }
@@ -210,18 +210,15 @@ class MainMenu {
   }
 
   createRecentSubMenu(updated) {
-    // give properties
-    
+    // give properties    
     const recentFiles = this.settings.get('recent')
-    console.log( this , recentFiles)
-    let files = [];
-   
+    let files = [];   
     recentFiles.forEach((filename) => {
       let mi = {}
       mi.label = filename
       mi.click = (menuItem) => {
         window.app = this.app        
-        this.app.tabs.newTab(fs.readFileSync(filename, 'utf8'), 0, path.basename(filename));
+        this.app.tabs.newTab(fs.readFileSync(filename, 'utf8'), 0, path.basename(filename), filename);
       }
       files.push(mi)
     })

debug.log

@@ -0,0 +1,2 @@
+[0221/112203:ERROR:tcp_listen_socket.cc(76)] Could not bind socket to 127.0.0.1:6004
+[0221/112203:ERROR:node_debugger.cc(86)] Cannot start debugger server

index.html

@@ -48,7 +48,6 @@
   <link rel="stylesheet" href="node_modules/codemirror/theme/seti.css" type="text/css">
   <link rel="stylesheet" href="node_modules/codemirror/theme/zenburn.css" type="text/css">
 
-
   <!-- JSON-Splora custom css -->
   <link rel="stylesheet" href="app/css/structure.css" type="text/css">
   <link rel="stylesheet" href="app/css/ui.css" type="text/css">