Avoid computations in the future

Author: wichtounet

src/overview.cpp

@@ -1151,24 +1151,28 @@ void budget::display_month_overview(budget::month month, budget::year year, budg
 
     const budget::date today = budget::local_day();
     const budget::date month_start(year, month, 1);
-    budget::date       month_end = month_start.end_of_month();
 
-    // If we are on the current month, we avoid going into the future
-    if (month_start.year() == today.year() && month_start.month() == today.month()) {
-        month_end = today;
-    }
+    // We cannot compute NW increases in the future
+    if (month_start.end_of_month() < today) {
+        budget::date month_end = month_start.end_of_month();
 
-    auto net_worth_end = get_net_worth(month_end, writer.cache);
-    auto net_worth_month_start = get_net_worth(month_start, writer.cache);
+        // If we are on the current month, we avoid going into the future
+        if (month_start.year() == today.year() && month_start.month() == today.month()) {
+            month_end = today;
+        }
 
-    auto month_increase = net_worth_end - net_worth_month_start;
+        auto net_worth_end = get_net_worth(month_end, writer.cache);
+        auto net_worth_month_start = get_net_worth(month_start, writer.cache);
 
-    second_contents.emplace_back(std::vector<std::string>{"Net Worth Increase", budget::to_string(month_increase)});
+        auto month_increase = net_worth_end - net_worth_month_start;
 
-    if (month_increase.zero() || month_increase.negative()) {
-        second_contents.emplace_back(std::vector<std::string>{"Savings Contribution", "N/A"});
-    } else {
-        second_contents.emplace_back(std::vector<std::string>{"Savings Contribution", budget::to_string(100.0 * (savings / month_increase)) + "%"});
+        second_contents.emplace_back(std::vector<std::string>{"Net Worth Increase", budget::to_string(month_increase)});
+
+        if (month_increase.zero() || month_increase.negative()) {
+            second_contents.emplace_back(std::vector<std::string>{"Savings Contribution", "N/A"});
+        } else {
+            second_contents.emplace_back(std::vector<std::string>{"Savings Contribution", budget::to_string(100.0 * (savings / month_increase)) + "%"});
+        }
     }
 
     writer.display_table(second_columns, second_contents, 1, {}, accounts.size() * 9 + 1);