refactor(plasmoid): use internal enum

Simplifies the code.

Author: romangg

plasma-integration/plasmoid/kdisplay_applet.cpp

@@ -22,8 +22,6 @@
  */
 #include "kdisplay_applet.h"
 
-#include "../osd/osdaction.h"
-
 #include <QMetaEnum>
 #include <QQmlEngine> // for qmlRegisterType
 
@@ -71,22 +69,17 @@ int KDisplayApplet::connectedOutputCount() const
     return m_connectedOutputCount;
 }
 
-void KDisplayApplet::applyLayoutPreset(Action action)
+void KDisplayApplet::applyLayoutPreset(KDisplay::OsdAction::Action action)
 {
     auto const actionEnum = QMetaEnum::fromType<KDisplay::OsdAction::Action>();
     Q_ASSERT(actionEnum.isValid());
 
-    const QString presetName = QString::fromLatin1(actionEnum.valueToKey(action));
-    if (presetName.isEmpty()) {
-        return;
-    }
-
     QDBusMessage msg = QDBusMessage::createMethodCall(QStringLiteral("org.kde.kded6"),
                                                       QStringLiteral("/modules/kdisplay"),
                                                       QStringLiteral("org.kwinft.kdisplay"),
                                                       QStringLiteral("applyLayoutPreset"));
 
-    msg.setArguments({presetName});
+    msg.setArguments({QString::fromLatin1(actionEnum.valueToKey(action))});
 
     QDBusConnection::sessionBus().call(msg, QDBus::NoBlock);
 }

plasma-integration/plasmoid/kdisplay_applet.h

@@ -22,8 +22,9 @@
  */
 #pragma once
 
-#include <Plasma/Applet>
+#include "../osd/osdaction.h"
 
+#include <Plasma/Applet>
 #include <disman/types.h>
 
 class KDisplayApplet : public Plasma::Applet
@@ -40,14 +41,11 @@ class KDisplayApplet : public Plasma::Applet
     explicit KDisplayApplet(QObject* parent, const KPluginMetaData& data, const QVariantList& args);
     ~KDisplayApplet() override;
 
-    enum Action { SwitchToExternal, SwitchToInternal, Clone, ExtendLeft, ExtendRight };
-    Q_ENUM(Action)
-
     void init() override;
 
     int connectedOutputCount() const;
 
-    Q_INVOKABLE void applyLayoutPreset(Action action);
+    Q_INVOKABLE void applyLayoutPreset(KDisplay::OsdAction::Action action);
 
 Q_SIGNALS:
     void connectedOutputCountChanged();