Skip to content

Commit e74a7ae

Browse files
authored
fix: append error cause when using logger.child() (#2467)
1 parent 8a956fd commit e74a7ae

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

lib/winston/logger.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ class Logger extends Transform {
6262
if (info instanceof Error) {
6363
infoClone.stack = info.stack;
6464
infoClone.message = info.message;
65+
infoClone.cause = info.cause;
6566
}
6667

6768
logger.write(infoClone);

test/unit/winston/logger.test.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -973,6 +973,8 @@ describe('Logger Instance', function () {
973973
assume(msg.message).equals('dummy error');
974974
assume(msg.stack).includes('logger.test.js');
975975
assume(msg.service).equals('user-service');
976+
assume(msg.cause.message).equals('dummy error cause');
977+
assume(msg.cause.stack).includes('logger.test.js');
976978
done();
977979
});
978980

@@ -983,7 +985,7 @@ describe('Logger Instance', function () {
983985
});
984986

985987
const childLogger = logger.child({service: 'user-service'});
986-
childLogger.error(Error('dummy error'));
988+
childLogger.error(Error('dummy error', { cause: Error('dummy error cause') }));
987989
});
988990

989991
it('defaultMeta() autobinds correctly', (done) => {

0 commit comments

Comments
 (0)