WPB-18320 make hardcoded images in helm charts configurable via values yaml (#5015)

Author: battermann

changelog.d/0-release-notes/WPB-18320

@@ -0,0 +1,8 @@
+The following Helm charts changed in this branch:
+- `charts/demo-smtp`
+- `charts/fake-aws-ses`
+- `charts/fake-aws-sns`
+- `charts/legalhold`
+
+Image field overrides are supported via split values (`repository` + `tag`) in the changed charts.
+There are backward incompatibilities if old string-style image overrides are still used.

changelog.d/5-internal/WPB-18320

@@ -0,0 +1 @@
+Made hard coded images in helm charts configurable

charts/demo-smtp/templates/deployment.yaml

@@ -28,7 +28,7 @@ spec:
               app: {{ template "demo-smtp.name" . }}
       containers:
         - name: {{ .Chart.Name }}
-          image: "{{ .Values.image }}"
+          image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
           env:
         {{- range $key, $val := .Values.envVars }}
             - name: {{ $key }}

charts/demo-smtp/values.yaml

@@ -1,6 +1,8 @@
 fullnameOverride: demo-smtp
 replicaCount: 1
-image: "quay.io/wire/ixdotai-smtp:v0.5.2"
+image:
+  repository: quay.io/wire/ixdotai-smtp
+  tag: v0.5.2
 
 service:
   port: 25

charts/fake-aws-ses/templates/deployment.yaml

@@ -44,7 +44,7 @@ spec:
         resources:
 {{ toYaml .Values.resources | indent 12 }}
       - name: initiate-fake-aws-ses
-        image: mesosphere/aws-cli:1.14.5
+        image: "{{ .Values.awsCliImage.repository }}:{{ .Values.awsCliImage.tag }}"
         command: [/bin/sh]
         args:
         - -c

charts/fake-aws-ses/values.yaml

@@ -2,6 +2,10 @@ image:
   repository: localstack/localstack
   tag: 0.8.7
 
+awsCliImage:
+  repository: mesosphere/aws-cli
+  tag: 1.14.5
+
 service:
   internalPort: 4579
   externalPort: 4569

charts/fake-aws-sns/templates/deployment.yaml

@@ -44,7 +44,7 @@ spec:
         resources:
 {{ toYaml .Values.resources | indent 12 }}
       - name: initiate-fake-aws-sns
-        image: mesosphere/aws-cli:1.14.5
+        image: "{{ .Values.awsCliImage.repository }}:{{ .Values.awsCliImage.tag }}"
         command: [/bin/sh]
         args:
         - -c

charts/fake-aws-sns/values.yaml

@@ -2,6 +2,10 @@ image:
   repository: localstack/localstack
   tag: 0.8.7
 
+awsCliImage:
+  repository: mesosphere/aws-cli
+  tag: 1.14.5
+
 service:
   internalPort: 4575
   externalPort: 4575

charts/legalhold/templates/deployment.yaml

@@ -27,7 +27,7 @@ spec:
       restartPolicy: Always
       containers:
         - name: hold
-          image: quay.io/wire/legalhold:1.0.2
+          image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
           imagePullPolicy: IfNotPresent
 
           resources:

charts/legalhold/values.yaml

@@ -14,6 +14,10 @@
 # The shared secret that the backend uses to authenticate to legalhold
 # serviceToken: ""
 
+image:
+  repository: quay.io/wire/legalhold
+  tag: 1.0.2
+
 podSecurityContext:
   allowPrivilegeEscalation: false
   capabilities: