WireMock Integration Tests#67
Merged
Merged
Conversation
oleg-nenashev
commented
Jul 6, 2023
| } | ||
|
|
||
| @Test | ||
| @Disabled("Needs a valid certificate. Otherwise, can run only with -Djdk.internal.httpclient.disableHostnameVerification=true") |
Member
Author
There was a problem hiding this comment.
I gave up with certificate generation for now
Member
Author
|
FTR an update after wiremock/wiremock-testcontainers-java#58 will be required. Can be done later when updating the version |
Mahoney
approved these changes
Jul 7, 2023
Member
Author
|
I will go ahead and merge it @rodolpheche. I want to add a WireMock 3 PoC and IMHO this is needed to have some coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I want to add integration tests, using the WireMock module for Testcontainers Java. It reuses the existing samples and enables deeper test coverage
Scope