Add JUnit5 test coverage and documentation#16
Merged
oleg-nenashev merged 4 commits intoApr 23, 2023
Merged
Conversation
Member
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
Thank you! Since we have multiple examples now, it would be great to also add titles to JUnit4 and JUnit5 examples so that they are visible in the table of contents
Contributor
Author
|
incorporated review comment |
Member
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
It would be nice to also update the ### Using the test container in JUnit 4/5 section with the JUnit 5 example. Arguably, JUnit 5 should go first and be used as a default in all other documentation sections that do not require both JUnit 4 and JUnit 5 examples
`
oleg-nenashev
approved these changes
Apr 23, 2023
Member
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
Thank you! I will see how to optimize the vertical size of the examples later, maybe with expandable sections. But it looks good content-wise
oleg-nenashev
added
documentation
oleg-nenashev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@oleg-nenashev I have added existing example tests in JUnit 5.
Resolves #8