Align WireMockContainer constructor with the Testcontainers certification requirements + Verify image and version compatibility in the constructor#58
Merged
Conversation
…tion requirements
eddumelendez
reviewed
Jul 6, 2023
|
Are AtomicJar's certification requirements online somewhere? |
Mahoney
approved these changes
Jul 7, 2023
Member
Author
Nope. There's a slidedeck, but I doubt I have the latest version. @eddumelendez is my source of the info 😄 |
4 tasks
bitxon
reviewed
Jul 8, 2023
bitxon
reviewed
Jul 8, 2023
| class WireMockContainerBannerTest { | ||
|
|
||
| WireMockContainer wireMockContainer = new WireMockContainer("2.35.0"); | ||
| WireMockContainer wireMockContainer = new WireMockContainer(WireMockContainer.WIREMOCK_2_LATEST); |
Contributor
There was a problem hiding this comment.
Maybe wold be better to use constructor without params in all tests
Member
Author
There was a problem hiding this comment.
I will later create a TestConfig class, similar to wiremock/wiremock-docker#67. It will include a static method for tests
Co-authored-by: Nikita Karpuk <bitxon.dev@gmail.com>
bitxon
approved these changes
Jul 10, 2023
eddumelendez
approved these changes
Jul 17, 2023
oleg-nenashev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the module constructors with the Official image requirements. It is a breaking change that I am not particularly fond of, but following AtomicJar's certification requirements:
WireMock(String)constructor now takes the full image string, not just version - BREAKINGReferences
compatibleSubstituteFor()through API testcontainers/testcontainers-java#7305 is ideally neededSubmitter checklist