Skip to content

Commit 788c099

Browse files
committed
Remove OTA metadata structure version block
If we cap the acceptable version, it becomes impossible to increase it: older firmwares will reject it. Instead we must guarantee backwards compatibility so long as the magic number is the same. If a breaking change is required in the future, a new magic number should be used to identify it.
1 parent ba21ab5 commit 788c099

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

wled00/wled_metadata.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -100,13 +100,6 @@ bool findWledMetadata(const uint8_t* binaryData, size_t dataSize, wled_metadata_
100100
wled_metadata_t candidate;
101101
memcpy(&candidate, binaryData + offset, sizeof(candidate));
102102

103-
// Found potential match, validate version
104-
if (candidate.desc_version > WLED_CUSTOM_DESC_VERSION) {
105-
DEBUG_PRINTF_P(PSTR("Found WLED structure at offset %u but version mismatch: %u\n"),
106-
offset, candidate.desc_version);
107-
continue;
108-
}
109-
110103
// Validate hash using runtime function
111104
uint32_t expected_hash = djb2_hash_runtime(candidate.release_name);
112105
if (candidate.hash != expected_hash) {

0 commit comments

Comments
 (0)