Skip to content
This repository was archived by the owner on Apr 5, 2022. It is now read-only.

Commit a51ab75

Browse files
author
Winni Neessen
authored
Merge pull request #14 from wneessen/dev
Dev
2 parents c1b4073 + c80d5ea commit a51ab75

File tree

6 files changed

+36
-16
lines changed

6 files changed

+36
-16
lines changed

dist/lib/websiteBenchConfig.d.ts.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/lib/websiteBenchConfig.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const process_1 = require("process");
55
class WebsiteBenchConfig {
66
constructor(confFiles, logObj) {
77
this._configObj = {};
8-
this._versionNum = '2.0.3b';
8+
this._versionNum = '2.0.4';
99
this._allowCaching = false;
1010
this._ignoreSslErrors = false;
1111
this._logResourceErrors = false;

dist/lib/websiteBenchEvents.d.ts.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/lib/websiteBenchEvents.js

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,22 @@ class WebsiteBenchEvents extends events_1.EventEmitter {
8181
});
8282
const startTime = Date.now();
8383
const perfObj = await this._browserObj.processPageWithBrowser(websiteEntry);
84-
perfJson = perfObj.perfData;
85-
this.sendDataToInflux(websiteEntry, perfJson, additionalTags);
86-
perfResourceJson = perfObj.resourcePerfData;
87-
perfResourceJson.forEach(perfResource => {
88-
this.sendDataToInflux(websiteEntry, perfResource, additionalTags);
89-
});
84+
if ('perfData' in perfObj && typeof perfObj.perfData !== 'undefined' && perfObj.perfData !== null) {
85+
perfJson = perfObj.perfData;
86+
this.sendDataToInflux(websiteEntry, perfJson, additionalTags);
87+
}
88+
else {
89+
this.logObj.warn('Request did not return any performance data. Not sending to InfluxDB');
90+
}
91+
if ('resourcePerfData' in perfObj && typeof perfObj.resourcePerfData !== 'undefined' && perfObj.resourcePerfData !== null) {
92+
perfResourceJson = perfObj.resourcePerfData;
93+
perfResourceJson.forEach(perfResource => {
94+
this.sendDataToInflux(websiteEntry, perfResource, additionalTags);
95+
});
96+
}
97+
else {
98+
this.logObj.warn('Request did not return any resource performance data. Not sending to InfluxDB');
99+
}
90100
const processingTime = Date.now() - startTime;
91101
this.logObj.debug(`Performance check completed in ${processingTime / 1000} seconds`);
92102
}

src/lib/websiteBenchConfig.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export default class WebsiteBenchConfig {
88
private _configObj: IWebsiteBenchConfig = {};
99

1010
// Defaults config settings
11-
private _versionNum = '2.0.3b';
11+
private _versionNum = '2.0.4';
1212
private _allowCaching = false;
1313
private _ignoreSslErrors = false;
1414
private _logResourceErrors = false;

src/lib/websiteBenchEvents.ts

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -140,14 +140,24 @@ export default class WebsiteBenchEvents extends EventEmitter {
140140
const perfObj = await this._browserObj.processPageWithBrowser(websiteEntry);
141141

142142
// Navigation page first
143-
perfJson = perfObj.perfData;
144-
this.sendDataToInflux(websiteEntry, perfJson, additionalTags);
143+
if('perfData' in perfObj && typeof perfObj.perfData !== 'undefined' && perfObj.perfData !== null) {
144+
perfJson = perfObj.perfData;
145+
this.sendDataToInflux(websiteEntry, perfJson, additionalTags);
146+
}
147+
else {
148+
this.logObj.warn('Request did not return any performance data. Not sending to InfluxDB');
149+
}
145150

146151
// Resource data next
147-
perfResourceJson = perfObj.resourcePerfData;
148-
perfResourceJson.forEach(perfResource => {
149-
this.sendDataToInflux(websiteEntry, perfResource, additionalTags);
150-
})
152+
if('resourcePerfData' in perfObj && typeof perfObj.resourcePerfData !== 'undefined' && perfObj.resourcePerfData !== null) {
153+
perfResourceJson = perfObj.resourcePerfData;
154+
perfResourceJson.forEach(perfResource => {
155+
this.sendDataToInflux(websiteEntry, perfResource, additionalTags);
156+
});
157+
}
158+
else {
159+
this.logObj.warn('Request did not return any resource performance data. Not sending to InfluxDB');
160+
}
151161

152162
const processingTime = Date.now() - startTime;
153163
this.logObj.debug(`Performance check completed in ${processingTime / 1000} seconds`);

0 commit comments

Comments
 (0)