Stabilize OpenWrt container CI for variable TLS fetch exit codes#10637
Draft
Copilot wants to merge 5 commits into
Draft
Stabilize OpenWrt container CI for variable TLS fetch exit codes#10637Copilot wants to merge 5 commits into
Copilot wants to merge 5 commits into
Conversation
|
Can one of the admins verify this patch? |
Copilot
AI
changed the title
[WIP] Fix the failing GitHub Actions job Compile container (22.03.6)
Stabilize OpenWrt container CI for variable TLS fetch exit codes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenWrt
Compile container (22.03.6)job was failing in the negative TLS test path, not because the request succeeded, but becauseuclient-fetchreturned a different non-zero code than the script expected. This change makes the test assert failure semantics instead of overfitting to a single exit code foruntrusted-root.badssl.com.Root cause
Docker/OpenWrt/runTests.shhard-coded exit code5foruclient-fetch 'https://untrusted-root.badssl.com/'.4(Connection reset prematurely).Test helper update
runCMD()to accept a set of allowed return codes.untrusted-root.badssl.comassertion from5to4 5.Shell hardening
Behavioral impact