Skip to content

20260608-atomic-fixes#10640

Open
douzzer wants to merge 1 commit into
wolfSSL:masterfrom
douzzer:20260608-atomic-fixes
Open

20260608-atomic-fixes#10640
douzzer wants to merge 1 commit into
wolfSSL:masterfrom
douzzer:20260608-atomic-fixes

Conversation

@douzzer

@douzzer douzzer commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

fixes for #10472 from AI review:
wolfcrypt/src/wc_port.c: fix several missed refactors to WC_ATOMIC_[U]INT_ARG.

wolfssl/wolfcrypt/wc_port.h:

  • harmonize the return type of WOLFSSL_ATOMIC_STORE() (always void).
  • fix MSVC WOLFSSL_ATOMIC_LOAD() and _STORE() with correct atomic semantics, and add gating on USE_WINDOWS_API.

tested with

wolfssl-multi-test.sh ...
check-source-text
'.*mingw.*'
clang-tidy-all-sp-all
'all-g\+\+-latest'

@douzzer douzzer added the For This Release Release version 5.9.2 label Jun 8, 2026

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10640

Scan targets checked: none
Failed targets: wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

⚠️ Review incomplete — one or more scan targets failed before findings could be produced. See the Fenrir PR review detail page for logs.

wolfcrypt/src/wc_port.c: fix several missed refactors to WC_ATOMIC_[U]INT_ARG.

wolfssl/wolfcrypt/wc_port.h:
* harmonize the return type of WOLFSSL_ATOMIC_STORE() (always void).
* fix MSVC WOLFSSL_ATOMIC_LOAD() and _STORE() with correct atomic semantics, and add gating on USE_WINDOWS_API.
@douzzer douzzer force-pushed the 20260608-atomic-fixes branch from feef4ce to 68144a8 Compare June 8, 2026 21:52
@douzzer

douzzer commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

retest this please
(mysterious glitch in PRB-valgrind-check-v3 despite "0 errors" and "Success for all configured tests.")

@douzzer

douzzer commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

note, the failing "Arduino CI Build" seems to be failing on

/home/runner/.arduino15/packages/arduino/tools/arm-none-eabi-gcc/7-2017q4/bin/../lib/gcc/arm-none-eabi/7.2.1/../../../../arm-none-eabi/bin/ld: /home/runner/.cache/arduino/sketches/E51C510243ED73B001195C94E940F85C/wolfssl_client.ino.elf section `.data' will not fit in region `FLASH'
/home/runner/.arduino15/packages/arduino/tools/arm-none-eabi-gcc/7-2017q4/bin/../lib/gcc/arm-none-eabi/7.2.1/../../../../arm-none-eabi/bin/ld: region `FLASH' overflowed by 4 bytes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For This Release Release version 5.9.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants