From b9891c67caaa5970725167e23caa0e2b3af11e19 Mon Sep 17 00:00:00 2001 From: Petros Paraskevopoulos Date: Wed, 12 Oct 2022 16:05:36 +0300 Subject: [PATCH 1/2] Analysis: Enable all warnings as errors for the wordpress module --- WordPress/build.gradle | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/WordPress/build.gradle b/WordPress/build.gradle index 1c705afb932a..2517bec05f5f 100644 --- a/WordPress/build.gradle +++ b/WordPress/build.gradle @@ -147,6 +147,10 @@ android { targetCompatibility JavaVersion.VERSION_1_8 } + kotlinOptions { + allWarningsAsErrors = true + } + flavorDimensions "app", "buildType" productFlavors { From d9a7eefb31b9142491560f4b118e90abd4c833c5 Mon Sep 17 00:00:00 2001 From: Petros Paraskevopoulos Date: Wed, 12 Oct 2022 16:24:54 +0300 Subject: [PATCH 2/2] Analysis: Enable all warnings as errors for all modules This 'allWarningsAsErrors' configuration was previously applied on the module level in order to make sure that, as the overall 'Kotlin Warnings as Errors' work is progressing, no new warnings are added to a specific module, which is already free of warnings. However, now that the overall 'Kotlin Warnings as Errors' work is complete on all modules, this module level 'allWarningsAsErrors' configuration is now replaced by a root level 'allWarningsAsErrors' configuration that will be applied by default to all modules. --- WordPress/build.gradle | 4 ---- build.gradle | 1 + libs/annotations/build.gradle | 6 ------ libs/editor/build.gradle | 4 ---- libs/image-editor/build.gradle | 4 ---- libs/processors/build.gradle | 6 ------ 6 files changed, 1 insertion(+), 24 deletions(-) diff --git a/WordPress/build.gradle b/WordPress/build.gradle index 2517bec05f5f..1c705afb932a 100644 --- a/WordPress/build.gradle +++ b/WordPress/build.gradle @@ -147,10 +147,6 @@ android { targetCompatibility JavaVersion.VERSION_1_8 } - kotlinOptions { - allWarningsAsErrors = true - } - flavorDimensions "app", "buildType" productFlavors { diff --git a/build.gradle b/build.gradle index 093444d20642..95be7069f569 100644 --- a/build.gradle +++ b/build.gradle @@ -113,6 +113,7 @@ allprojects { tasks.withType(KotlinCompile).all { kotlinOptions { jvmTarget = JavaVersion.VERSION_1_8 + allWarningsAsErrors = true freeCompilerArgs += [ "-Xopt-in=kotlin.RequiresOptIn" ] diff --git a/libs/annotations/build.gradle b/libs/annotations/build.gradle index 84b34ef27608..546933fb729d 100644 --- a/libs/annotations/build.gradle +++ b/libs/annotations/build.gradle @@ -1,9 +1,3 @@ plugins { id "org.jetbrains.kotlin.jvm" } - -compileKotlin { - kotlinOptions { - allWarningsAsErrors = true - } -} diff --git a/libs/editor/build.gradle b/libs/editor/build.gradle index 134e321d1d81..efc0cdc1440b 100644 --- a/libs/editor/build.gradle +++ b/libs/editor/build.gradle @@ -40,10 +40,6 @@ android { targetSdkVersion rootProject.targetSdkVersion } - kotlinOptions { - allWarningsAsErrors = true - } - // Avoid 'duplicate files during packaging of APK' errors packagingOptions { exclude 'LICENSE.txt' diff --git a/libs/image-editor/build.gradle b/libs/image-editor/build.gradle index 095260bf47eb..46a4fee55134 100644 --- a/libs/image-editor/build.gradle +++ b/libs/image-editor/build.gradle @@ -18,10 +18,6 @@ android { vectorDrawables.useSupportLibrary = true } - kotlinOptions { - allWarningsAsErrors = true - } - sourceSets { main.java.srcDirs += 'src/main/kotlin' test.java.srcDirs += 'src/test/kotlin' diff --git a/libs/processors/build.gradle b/libs/processors/build.gradle index 4d72bbb32b3a..4a21fcb9f1c4 100644 --- a/libs/processors/build.gradle +++ b/libs/processors/build.gradle @@ -3,12 +3,6 @@ plugins { id "org.jetbrains.kotlin.kapt" } -compileKotlin { - kotlinOptions { - allWarningsAsErrors = true - } -} - dependencies { implementation project(':libs:annotations') implementation "com.google.auto.service:auto-service:$autoServiceVersion"