From 13f6afdbbe35db46ebac7801c50d2c1cc11dc1ee Mon Sep 17 00:00:00 2001 From: Nick Bradbury Date: Mon, 26 Jan 2015 14:32:20 -0500 Subject: [PATCH] Theme live preview no longer changes the activity title --- .../ui/themes/ThemePreviewFragment.java | 7 +++-- .../android/util/WPWebChromeClient.java | 28 +++++++++++++------ 2 files changed, 25 insertions(+), 10 deletions(-) diff --git a/WordPress/src/main/java/org/wordpress/android/ui/themes/ThemePreviewFragment.java b/WordPress/src/main/java/org/wordpress/android/ui/themes/ThemePreviewFragment.java index 1d6203632612..a6c979d1ab30 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/themes/ThemePreviewFragment.java +++ b/WordPress/src/main/java/org/wordpress/android/ui/themes/ThemePreviewFragment.java @@ -134,8 +134,11 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle sa mWebView.getSettings().setUserAgentString(DESKTOP_UA); mWebView.setScrollBarStyle(View.SCROLLBARS_INSIDE_OVERLAY); - mWebView.setWebChromeClient(new WPWebChromeClient(getActivity(), (ProgressBar) view.findViewById( - R.id.progress_bar))); + mWebView.setWebChromeClient( + new WPWebChromeClient( + getActivity(), + (ProgressBar) view.findViewById(R.id.progress_bar), + false)); mWebView.setWebViewClient(new WPWebViewClient(mBlog)); diff --git a/libs/utils/WordPressUtils/src/main/java/org/wordpress/android/util/WPWebChromeClient.java b/libs/utils/WordPressUtils/src/main/java/org/wordpress/android/util/WPWebChromeClient.java index 6a40c6f3807b..6d640fc3f27a 100644 --- a/libs/utils/WordPressUtils/src/main/java/org/wordpress/android/util/WPWebChromeClient.java +++ b/libs/utils/WordPressUtils/src/main/java/org/wordpress/android/util/WPWebChromeClient.java @@ -7,23 +7,35 @@ import android.widget.ProgressBar; public class WPWebChromeClient extends WebChromeClient { - private ProgressBar mProgressBar; - private Activity mActivity; + private final ProgressBar mProgressBar; + private final Activity mActivity; + private final boolean mAutoUpdateActivityTitle; public WPWebChromeClient(Activity activity, ProgressBar progressBar) { + mActivity = activity; mProgressBar = progressBar; + mAutoUpdateActivityTitle = true; + } + + public WPWebChromeClient(Activity activity, + ProgressBar progressBar, + boolean autoUpdateActivityTitle) { mActivity = activity; + mProgressBar = progressBar; + mAutoUpdateActivityTitle = autoUpdateActivityTitle; } public void onProgressChanged(WebView webView, int progress) { - if (!mActivity.isFinishing()) { + if (mActivity != null && !mActivity.isFinishing() && mAutoUpdateActivityTitle) { mActivity.setTitle(webView.getTitle()); } - if (progress == 100) { - mProgressBar.setVisibility(View.GONE); - } else { - mProgressBar.setVisibility(View.VISIBLE); - mProgressBar.setProgress(progress); + if (mProgressBar != null) { + if (progress == 100) { + mProgressBar.setVisibility(View.GONE); + } else { + mProgressBar.setVisibility(View.VISIBLE); + mProgressBar.setProgress(progress); + } } } } \ No newline at end of file