From 9578e91743d1fc7920f7275ba4fa628e2a80fbbd Mon Sep 17 00:00:00 2001 From: Gio Lodi Date: Thu, 3 Apr 2025 16:58:56 +1100 Subject: [PATCH 1/3] Update access level for some methods that will soon be in WordPressData --- WordPress/Classes/Models/Blog/Blog+SelfHosted.swift | 6 +++--- WordPress/Classes/Models/Media.swift | 2 +- .../Classes/Models/Site Creation/SiteInformation.swift | 10 +++++----- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/WordPress/Classes/Models/Blog/Blog+SelfHosted.swift b/WordPress/Classes/Models/Blog/Blog+SelfHosted.swift index 82a2a0a95724..44d743e6e123 100644 --- a/WordPress/Classes/Models/Blog/Blog+SelfHosted.swift +++ b/WordPress/Classes/Models/Blog/Blog+SelfHosted.swift @@ -3,7 +3,7 @@ import CryptoKit import WordPressAPI import WordPressShared -extension Blog { +public extension Blog { enum BlogCredentialsError: Error { case blogUrlMissing @@ -64,7 +64,7 @@ extension Blog { @available(swift, obsoleted: 1.0) @objc(deleteApplicationToken) - public func objc_deleteApplicationToken() { + func objc_deleteApplicationToken() { _ = try? deleteApplicationToken() } @@ -159,7 +159,7 @@ extension Blog { } } -extension WpApiApplicationPasswordDetails { +public extension WpApiApplicationPasswordDetails { var derivedXMLRPCRoot: URL { get throws { let url = try ParsedUrl.parse(input: siteUrl).asURL() diff --git a/WordPress/Classes/Models/Media.swift b/WordPress/Classes/Models/Media.swift index a3dffde1076f..c07a46eaf52e 100644 --- a/WordPress/Classes/Models/Media.swift +++ b/WordPress/Classes/Models/Media.swift @@ -1,7 +1,7 @@ import Foundation import UniformTypeIdentifiers -extension Media { +public extension Media { // MARK: - AutoUpload Failure Count static let maxAutoUploadFailureCount = 3 diff --git a/WordPress/Classes/Models/Site Creation/SiteInformation.swift b/WordPress/Classes/Models/Site Creation/SiteInformation.swift index 047ef31ee541..dc0000d222af 100644 --- a/WordPress/Classes/Models/Site Creation/SiteInformation.swift +++ b/WordPress/Classes/Models/Site Creation/SiteInformation.swift @@ -1,9 +1,9 @@ -struct SiteInformation { - let title: String - let tagLine: String? +public struct SiteInformation { + public let title: String + public let tagLine: String? /// if title is nil, then the corresponding SiteInformation value is nil - init?(title: String?, tagLine: String?) { + public init?(title: String?, tagLine: String?) { guard let title else { return nil } @@ -13,7 +13,7 @@ struct SiteInformation { } extension SiteInformation: Equatable { - static func ==(lhs: SiteInformation, rhs: SiteInformation) -> Bool { + public static func ==(lhs: SiteInformation, rhs: SiteInformation) -> Bool { return lhs.title == rhs.title && lhs.tagLine == rhs.tagLine } From 6163ea725f3ece5d61460142427e1c98b303f8f5 Mon Sep 17 00:00:00 2001 From: Gio Lodi Date: Thu, 3 Apr 2025 21:23:34 +1100 Subject: [PATCH 2/3] Remove an unused forward declaration from `Blog.h` --- WordPress/Classes/Models/Blog/Blog.h | 1 - 1 file changed, 1 deletion(-) diff --git a/WordPress/Classes/Models/Blog/Blog.h b/WordPress/Classes/Models/Blog/Blog.h index 4260df5add2d..667b40ac7755 100644 --- a/WordPress/Classes/Models/Blog/Blog.h +++ b/WordPress/Classes/Models/Blog/Blog.h @@ -14,7 +14,6 @@ NS_ASSUME_NONNULL_BEGIN @class UserSuggestion; @class SiteSuggestion; @class PageTemplateCategory; -@class JetpackFeaturesRemovalCoordinator; @class PublicizeInfo; extern NSString * const BlogEntityName; From d868f93235546334ab2af9928235cf6784d0b250 Mon Sep 17 00:00:00 2001 From: Gio Lodi Date: Thu, 3 Apr 2025 21:25:25 +1100 Subject: [PATCH 3/3] Remove unused `AccountService` import from `Blog.m` It matters because once `Blog` is in WordPressData, `AccountService` will no longer be available. --- WordPress/Classes/Models/Blog/Blog.m | 1 - 1 file changed, 1 deletion(-) diff --git a/WordPress/Classes/Models/Blog/Blog.m b/WordPress/Classes/Models/Blog/Blog.m index ad3e48f0afe9..044b438f3ce4 100644 --- a/WordPress/Classes/Models/Blog/Blog.m +++ b/WordPress/Classes/Models/Blog/Blog.m @@ -1,6 +1,5 @@ #import "Blog.h" #import "WPAccount.h" -#import "AccountService.h" @import WordPressDataObjC; @import WordPressShared; #ifdef KEYSTONE