Skip to content
This repository was archived by the owner on May 18, 2022. It is now read-only.

Mock machine coding 2 | Jigar wala#11

Open
itsjwala wants to merge 2 commits into
workattech:masterfrom
itsjwala:master
Open

Mock machine coding 2 | Jigar wala#11
itsjwala wants to merge 2 commits into
workattech:masterfrom
itsjwala:master

Conversation

@itsjwala

@itsjwala itsjwala commented Oct 2, 2019

Copy link
Copy Markdown

No description provided.

Comment thread src/main/java/Pair.java
@@ -0,0 +1,67 @@
public class Pair {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use a better name since it is not a generic pair.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, It was in my mind, but didn't changed it later.

@gcnit

gcnit commented Oct 4, 2019

Copy link
Copy Markdown
Collaborator

@jigarWala sorry for the delay! Was busy at work.

Code looks pretty good!

Gave a comment. Please check.

@itsjwala

itsjwala commented Oct 4, 2019

Copy link
Copy Markdown
Author

Thanks @gcnit for the review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants