Skip to content
This repository was archived by the owner on May 18, 2022. It is now read-only.

solved the problem#5

Open
Susmita-code007 wants to merge 1 commit into
workattech:masterfrom
Susmita-code007:master
Open

solved the problem#5
Susmita-code007 wants to merge 1 commit into
workattech:masterfrom
Susmita-code007:master

Conversation

@Susmita-code007

Copy link
Copy Markdown

No description provided.

Comment thread driver.cpp
cout << "for a specific user?" << endl;
string ans;
cin >> ans;
if (ans == "YES" || ans == "Yes" || ans == "yes")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should follow the same format as mentioned in the problem statement at least during the interview.

Comment thread split_service.cpp
users.push_back(user_id);
}

void SplitService::EXPENSE_EQUAL(int total, string payer, vector <string> table)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

method name in capital case?

Comment thread split_service.cpp
users.push_back(user_id);
}

void SplitService::EXPENSE_EQUAL(int total, string payer, vector <string> table)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why named table?

@gcnit

gcnit commented Oct 4, 2019

Copy link
Copy Markdown
Collaborator

@Susmita-code007 sorry for the delay! Was busy at work.

Code looks good!

Gave a few comments. Please check.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants