Stop unnecessarily setting screen_hint=sign-in#107
Merged
Conversation
It's counter-productive to send this parameter because it prevents us from contextually redirecting user's back to the sign-up page when clients are behaving properly.
mthadley
reviewed
Jan 9, 2026
| organizationId?: string; | ||
| passwordResetToken?: string; | ||
| state?: any; | ||
| type: "sign-in" | "sign-up"; |
Contributor
There was a problem hiding this comment.
Removing type is a breaking change, right? Do we want to be backwards compatible?
Collaborator
Author
There was a problem hiding this comment.
hmm, this is a private interface so i don't think backwards compat is affected?
Contributor
There was a problem hiding this comment.
Ah, I glossed over that the references in the public method interfaces are actually Omit-ing this. My bad.
mthadley
approved these changes
Jan 9, 2026
This was referenced Jan 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's counter-productive to send this parameter because it prevents us from contextually redirecting user's back to the sign-up page when clients aren't behaving properly.