Lower PHP version requirement to 7.2#111
Merged
Merged
Conversation
Member
|
Looks OK -- we can also drop it to 7.2 if that means not needing to add 7.1 to our test matrix (since the original issue is really that it causes problems on 7.2 specifically). Does that seem easier? I think it is already the case that PHP 7.2 is the minimum version of PHP anybody actually has the ability to test against locally since getting 5.6 running is pretty hard and not a priority given its soon to be removal. |
mrsdizzie
approved these changes
Mar 10, 2025
Member
Author
|
Sure, that works for me. Makes it easier long term where we'll land on 7.2 eventually for the rest too. |
swissspidy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #110