Skip to content

Commit 062bef3

Browse files
committed
Merge pull request crosswalk-project#1124 from gramakri-intel/buildfix
Build fix, destructor must be virtual
2 parents 33e1d07 + d28485d commit 062bef3

File tree

4 files changed

+4
-2
lines changed

4 files changed

+4
-2
lines changed

application/browser/application_process_manager.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class Manifest;
3535
class ApplicationProcessManager : public RuntimeRegistryObserver {
3636
public:
3737
explicit ApplicationProcessManager(xwalk::RuntimeContext* runtime_context);
38-
~ApplicationProcessManager();
38+
virtual ~ApplicationProcessManager();
3939

4040
bool LaunchApplication(xwalk::RuntimeContext* runtime_context,
4141
const Application* application);

sysapps/raw_socket/raw_socket_object.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include "xwalk/sysapps/raw_socket/raw_socket.h"
99
#include "xwalk/sysapps/common/event_target.h"
1010

11-
using namespace xwalk::jsapi::raw_socket; // NOLINT
11+
using xwalk::jsapi::raw_socket::ReadyState; // NOLINT
1212

1313
namespace xwalk {
1414
namespace sysapps {

sysapps/raw_socket/tcp_server_socket_object.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
#include "xwalk/sysapps/raw_socket/tcp_socket_object.h"
1818

1919
using namespace xwalk::jsapi::tcp_server_socket; // NOLINT
20+
using namespace xwalk::jsapi::raw_socket; // NOLINT
2021

2122
namespace xwalk {
2223
namespace sysapps {

sysapps/raw_socket/tcp_socket_object.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#include "xwalk/sysapps/raw_socket/tcp_socket.h"
1212

1313
using namespace xwalk::jsapi::tcp_socket; // NOLINT
14+
using namespace xwalk::jsapi::raw_socket; // NOLINT
1415

1516
namespace {
1617

0 commit comments

Comments
 (0)