Skip to content

Commit 84894ce

Browse files
psmarshallCommit Bot
authored andcommitted
Reland "[cpu-profiler] Turn on detailed line info for optimized code"
This is a reland of 898f880 Original change's description: > [cpu-profiler] Turn on detailed line info for optimized code > > Cautiously turn on this flag by default to check the impact on > performance bots. Could show minor regressions in old space and/or > code_and_metadata memory buckets. > > Bug: v8:7983 > Change-Id: Ic4369cdb0231f4f88eada699da948e8bb48a25fd > Reviewed-on: https://chromium-review.googlesource.com/1162234 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54908} Bug: v8:7983 Change-Id: Iff53bc19c92f26f386948bd4a58e8dcf0493cf0d Reviewed-on: https://chromium-review.googlesource.com/1177481 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#55156}
1 parent 0c85d81 commit 84894ce

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/flag-definitions.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1257,9 +1257,8 @@ DEFINE_BOOL(log_function_events, false,
12571257
DEFINE_BOOL(prof, false,
12581258
"Log statistical profiling information (implies --log-code).")
12591259

1260-
DEFINE_BOOL(detailed_line_info, false,
1260+
DEFINE_BOOL(detailed_line_info, true,
12611261
"Always generate detailed line information for CPU profiling.")
1262-
DEFINE_IMPLICATION(future, detailed_line_info)
12631262

12641263
#if defined(ANDROID)
12651264
// Phones and tablets have processors that are much slower than desktop

0 commit comments

Comments
 (0)