Skip to content

Commit 9aeaf19

Browse files
committed
Merge remote-tracking branch 'upstream/master' into node-requirable
Conflicts: Gruntfile.js
2 parents e7991a9 + 35f0931 commit 9aeaf19

File tree

174 files changed

+18280
-4367
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

174 files changed

+18280
-4367
lines changed

.travis.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,24 @@ language: node_js
22
node_js:
33
- "0.10"
44
before_install:
5-
- time sudo pip install --use-mirrors -r test-infra/requirements.txt
5+
- travis_retry sudo pip install -r test-infra/requirements.txt
66
- rvm use 1.9.3 --fuzzy
77
- export GEMDIR=$(rvm gemdir)
8-
- if [ "$TWBS_TEST" = validate-html ]; then echo "ruby=$(basename $GEMDIR) jekyll=$JEKYLL_VERSION" > pseudo_Gemfile.lock; fi
8+
- if [ "$TWBS_TEST" = validate-html ]; then echo "ruby=$(basename $GEMDIR) jekyll=$JEKYLL_VERSION rouge=$ROUGE_VERSION" > pseudo_Gemfile.lock; fi
99
- "export TRAVIS_COMMIT_MSG=\"$(git log --format=%B --no-merges -n 1)\""
1010
- echo "$TRAVIS_COMMIT_MSG" | grep '\[skip validator\]'; export TWBS_DO_VALIDATOR=$?; true
1111
- echo "$TRAVIS_COMMIT_MSG" | grep '\[skip sauce\]'; export TWBS_DO_SAUCE=$?; true
1212
install:
13-
- time npm install -g grunt-cli
13+
- npm install -g grunt-cli
1414
- ./test-infra/s3_cache.py download npm-modules
1515
- if [ "$TWBS_TEST" = validate-html ] && [ $TWBS_DO_VALIDATOR -ne 0 ]; then ./test-infra/s3_cache.py download rubygems; fi
1616
after_script:
1717
- if [ "$TWBS_TEST" = core ]; then ./test-infra/s3_cache.py upload npm-modules; fi
1818
- if [ "$TWBS_TEST" = validate-html ] && [ $TWBS_DO_VALIDATOR -ne 0 ]; then ./test-infra/s3_cache.py upload rubygems; fi
1919
env:
2020
global:
21-
- JEKYLL_VERSION: 2.0.3
21+
- JEKYLL_VERSION: 2.3.0
22+
- ROUGE_VERSION: 1.6.2
2223
- SAUCE_USERNAME: bootstrap
2324
- secure: "pJkBwnuae9dKU5tEcCqccfS1QQw7/meEcfz63fM7ba7QJNjoA6BaXj08L5Z3Vb5vBmVPwBawxo5Hp0jC0r/Z/O0hGnAmz/Cz09L+cy7dSAZ9x4hvZePSja/UAusaB5ogMoO8l2b773MzgQeSmrLbExr9BWLeqEfjC2hFgdgHLaQ="
2425
- secure: "gqjqISbxBJK6byFbsmr1AyP1qoWH+rap06A2gI7v72+Tn2PU2nYkIMUkCvhZw6K889jv+LhQ/ybcBxDOXHpNCExCnSgB4dcnmYp+9oeNZb37jSP0rQ+Ib4OTLjzc3/FawE/fUq5kukZTC7porzc/k0qJNLAZRx3YLALmK1GIdUY="

CONTRIBUTING.md

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ Guidelines for bug reports:
4444

4545
3. **Isolate the problem** — ideally create a [reduced test
4646
case](http://css-tricks.com/6263-reduced-test-cases/) and a live example.
47-
[This JS Bin](http://jsbin.com/EBAwOkOK/1) is a helpful template.
47+
[This JS Bin](http://jsbin.com/lefey/1/edit?html,output) is a helpful template.
4848

4949

5050
A good bug report shouldn't leave others needing to chase you up for more
@@ -154,26 +154,16 @@ license your work under the terms of the [MIT License](LICENSE.md).
154154

155155
### HTML
156156

157-
- Two spaces for indentation, never tabs.
158-
- Double quotes only, never single quotes.
159-
- Always use proper indentation.
157+
[Adhere to the Code Guide.](http://codeguide.co/#html)
158+
160159
- Use tags and elements appropriate for an HTML5 doctype (e.g., self-closing tags).
161160
- Use CDNs and HTTPS for third-party JS when possible. We don't use protocol-relative URLs in this case because they break when viewing the page locally via `file://`.
162161
- Use [WAI-ARIA](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA) attributes in documentation examples to promote accessibility.
163162

164163
### CSS
165164

166-
- CSS changes must be done in `.less` files first, never just in the compiled `.css` files.
167-
- Adhere to the [CSS property order](http://markdotto.com/2011/11/29/css-property-order/).
168-
- Multiple-line approach (one property and value per line).
169-
- Always a space after a property's colon (e.g., `display: block;` and not `display:block;`).
170-
- End all lines with a semi-colon.
171-
- For multiple, comma-separated selectors, place each selector on its own line.
172-
- Don't add vendor prefixed properties to their unprefixed counterparts (e.g., only `box-sizing` and not also include `-webkit-box-sizing`), as this is done automagically at build time.
173-
- Attribute selectors, like `input[type="text"]` should always wrap the attribute's value in double quotes, for consistency and safety (see this [blog post on unquoted attribute values](http://mathiasbynens.be/notes/unquoted-attribute-values) that can lead to XSS attacks).
174-
- Attribute selectors should only be used where absolutely necessary (e.g., form controls) and should be avoided on custom components for performance and explicitness.
175-
- Series of classes for a component should include a base class (e.g., `.component`) and use the base class as a prefix for modifier and sub-components (e.g., `.component-lg`).
176-
- Avoid inheritance and over nesting—use single, explicit classes whenever possible.
165+
[Adhere to the Code Guide.](http://codeguide.co/#css)
166+
177167
- When feasible, default color palettes should comply with [WCAG color contrast guidelines](http://www.w3.org/TR/WCAG20/#visual-audio-contrast).
178168
- Except in rare cases, don't remove default `:focus` styles (via e.g. `outline: none;`) without providing alternative styles. See [this A11Y Project post](http://a11yproject.com/posts/never-remove-css-outlines/) for more details.
179169

0 commit comments

Comments
 (0)