Colors incorrect

[thekid]

Info is being displayed in red, debug in black on white background when using the ColoredConsoleAppender class.

The bug was introduced in a7ab39ea and is inside the constructor, line 35:

$this->colors= array_merge(self::$DEFAULTS, $colors);

The problem is that array_merge() will renumber the keys of the array (which is stated in the manual), but we're using the loglevels, which are non-continuously-numbered integers, as keys:

$ xp -d 'array_merge([8 => "eight"], [1 => "one"])'
array(2) {
  [0]=>
  string(5) "eight"
  [1]=>
  string(3) "one"
}

[thekid]

The correct function in this case is array_replace:

*array_replace() replaces the values of array1 with values having the same keys in each of the following arrays. If a key from the first array exists in the second array, its value will be replaced by the value from the second array. If the key exists in the second array, and not the first, it will be created in the first array. If a key only exists in the first array, it will be left as is. If several arrays are passed for replacement, they will be processed in order, the later arrays overwriting the previous values. *

# Empty second array -> result is first array; keys left intact
$ xp -d 'array_replace([1 => "warn", 2 => "error", 8 => "debug"], [])'
array(3) {
  [1]=>
  string(4) "warn"
  [2]=>
  string(5) "error"
  [8]=>
  string(5) "debug"
}

# Values in second array overwrite values in first; keys left intact as above
$ xp -d 'array_replace([1 => "warn", 2 => "error", 8 => "debug"], [8 => "debug (overwritten)"])'
array(3) {
  [1]=>
  string(4) "warn"
  [2]=>
  string(5) "error"
  [8]=>
  string(19) "debug (overwritten)"
}

# Values only in second array are added, keys intact as above
$ xp -d 'array_replace([1 => "warn", 2 => "error", 8 => "debug"], [0 => "info"])'
array(4) {
  [1]=>
  string(4) "warn"
  [2]=>
  string(5) "error"
  [8]=>
  string(5) "debug"
  [0]=>
  string(4) "info"
}