Skip to content

Conversation

@AntoinePrv
Copy link
Contributor

@AntoinePrv AntoinePrv commented Dec 8, 2022

Checklist

  • The title and commit message(s) are descriptive.
  • Small commits made to fix your PR have been squashed to avoid history pollution.
  • Tests have been added for new features or bug fixes.
  • API of new functions and classes are documented.

Description

Fix xtensor-stack/xtensor-r#85
Solution discussed with @JohanMabille

@AntoinePrv AntoinePrv marked this pull request as draft December 8, 2022 10:17
@AntoinePrv
Copy link
Contributor Author

So it turns out, after compilation succeed, there is a second issue.

When the shape (inner_shape) is copied, it may be an xbuffer_adaptor, so the follwowing lines actually modify the shape.

auto keep_dim_shape = e.shape();

@AntoinePrv AntoinePrv marked this pull request as ready for review December 8, 2022 13:56
@JohanMabille JohanMabille merged commit c06ec26 into xtensor-stack:master Dec 9, 2022
@AntoinePrv AntoinePrv deleted the get_strides_type branch December 23, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xt::variance() bug?

2 participants