fix(lifecycle): remove dead q.Style write, keep cache invalidation (#495)

* fix(lifecycle): remove dead q.Style write, keep cache invalidation

- Remove dead q.Style assignment in RecursiveGridComponent.UpdateConfig
  (q.Style was never read - renderer holds its own copy)
- Keep SetConfig call to invalidate C caches for theme changes
- Reorder calls: modes.UpdateConfig first (updates renderer style),
  then recursiveGridComponent.UpdateConfig (frees overlay caches)
- Eliminates theoretical data race on q.Style during config reload

* fix(lifecycle): restore cache-invalidation-before-draw ordering in handleThemeChange

* refactor(components): remove stale Style and ThemeProvider fields from RecursiveGridComponent

These fields were only set at construction time and read once during
renderer initialization. After the first config reload they silently
became stale because UpdateConfig no longer rebuilds the Style. All
runtime style updates flow through modes.UpdateConfig →
renderer.UpdateConfig, so the fields are unnecessary.
Remove both fields and build the initial renderer style directly from
config at initialization time.

* refactor(init): build all overlay styles on-demand from live config

Apply the same on-demand style building pattern to hints and grid
that was already applied to recursive_grid. This eliminates the
architectural inconsistency where two of three components carried
a Style field read at renderer init time while the third did not.

* docs(lifecycle): fix handleThemeChange comment to match actual call chain

Author: y3owk1n

internal/app/app_initialization_steps.go

@@ -171,33 +171,17 @@ func initializeSystrayComponent(app *App) {
 // initializeRendererAndOverlays sets up the overlay renderer and registers
 // all overlays with the overlay manager.
 func initializeRendererAndOverlays(app *App) {
-	// Get styles with nil-safe fallbacks
-	var hintStyle hints.StyleMode
-	if app.hintsComponent != nil {
-		hintStyle = app.hintsComponent.Style
-	} else {
-		// Fallback to default style if component is nil
-		hintStyle = hints.BuildStyle(config.DefaultConfig().Hints)
-	}
+	// Build styles directly from config + live theme provider rather than
+	// reading component fields that would go stale after config reloads.
+	cfg := config.DefaultConfig()
 
-	var gridStyle grid.Style
-	if app.gridComponent != nil {
-		gridStyle = app.gridComponent.Style
-	} else {
-		// Fallback to default style if component is nil
-		gridStyle = grid.BuildStyle(config.DefaultConfig().Grid)
+	if app.config != nil {
+		cfg = app.config
 	}
 
-	var recursiveGridStyle recursivegrid.Style
-	if app.recursiveGridComponent != nil {
-		recursiveGridStyle = app.recursiveGridComponent.Style
-	} else {
-		// Fallback to default style if component is nil
-		recursiveGridStyle = recursivegrid.BuildStyle(
-			config.DefaultConfig().RecursiveGrid,
-			defaultThemeProvider,
-		)
-	}
+	hintStyle := hints.BuildStyle(cfg.Hints)
+	gridStyle := grid.BuildStyle(cfg.Grid)
+	recursiveGridStyle := recursivegrid.BuildStyle(cfg.RecursiveGrid, defaultThemeProvider)
 
 	app.renderer = ui.NewOverlayRenderer(
 		app.overlayManager,

internal/app/component_factory.go

@@ -243,10 +243,8 @@ func (f *ComponentFactory) CreateRecursiveGridComponent(
 	}
 
 	return &components.RecursiveGridComponent{
-		Overlay:       recursiveGridOverlay,
-		Context:       &recursivegrid.Context{},
-		Style:         recursivegrid.BuildStyle(f.config.RecursiveGrid, defaultThemeProvider),
-		ThemeProvider: defaultThemeProvider,
+		Overlay: recursiveGridOverlay,
+		Context: &recursivegrid.Context{},
 	}, nil
 }
 

internal/app/components/types.go

@@ -106,19 +106,14 @@ func (m *ModeIndicatorComponent) UpdateConfig(cfg *config.Config, _ *zap.Logger)
 
 // RecursiveGridComponent encapsulates all recursive-grid-related functionality.
 type RecursiveGridComponent struct {
-	Manager       *domainRecursiveGrid.Manager
-	Overlay       *recursivegrid.Overlay
-	Context       *recursivegrid.Context
-	Style         recursivegrid.Style
-	ThemeProvider config.ThemeProvider
+	Manager *domainRecursiveGrid.Manager
+	Overlay *recursivegrid.Overlay
+	Context *recursivegrid.Context
 }
 
 // UpdateConfig updates the recursive-grid component with new configuration.
 func (q *RecursiveGridComponent) UpdateConfig(cfg *config.Config, _ *zap.Logger) {
-	if cfg.RecursiveGrid.Enabled {
-		q.Style = recursivegrid.BuildStyle(cfg.RecursiveGrid, q.ThemeProvider)
-		if q.Overlay != nil {
-			q.Overlay.SetConfig(cfg.RecursiveGrid)
-		}
+	if cfg.RecursiveGrid.Enabled && q.Overlay != nil {
+		q.Overlay.SetConfig(cfg.RecursiveGrid)
 	}
 }

internal/app/lifecycle.go

@@ -543,11 +543,14 @@ func (a *App) handleThemeChange(isDark bool) {
 		return
 	}
 
-	// Re-build styles with the new theme state
+	// Invalidate the overlay's native C string caches (via SetConfig →
+	// styleCache.Free + freeLabelCache) so the subsequent draw rebuilds
+	// them with the new theme-resolved colors.
 	if a.recursiveGridComponent != nil {
 		a.recursiveGridComponent.UpdateConfig(cfg, a.logger)
 	}
 
+	// Re-build renderer style with the new theme state, then redraw.
 	if a.modes != nil {
 		a.modes.UpdateConfig(cfg)
 

internal/app/modes/recursive_grid.go

@@ -87,11 +87,6 @@ func (h *Handler) initializeRecursiveGridManager(screenBounds image.Rectangle) {
 	if h.recursiveGrid == nil {
 		h.recursiveGrid = &components.RecursiveGridComponent{
 			Context: &componentrecursivegrid.Context{},
-			Style: componentrecursivegrid.BuildStyle(
-				h.config.RecursiveGrid,
-				h.themeProvider,
-			),
-			ThemeProvider: h.themeProvider,
 		}
 	}