Additional response withQuery is inconsistent when navigating to next page#103
Open
abudawud wants to merge 1 commit intoyajra:10.0from
Open
Additional response withQuery is inconsistent when navigating to next page#103abudawud wants to merge 1 commit intoyajra:10.0from
abudawud wants to merge 1 commit intoyajra:10.0from
Conversation
yajra
reviewed
Dec 28, 2023
| return DataTables::eloquent($model) | ||
| ->withQuery('count', function($filteredQuery) { | ||
| // remove limit and offset firstly | ||
| $filteredQuery->limit = null; |
Owner
There was a problem hiding this comment.
When using eloquent builder, this works instead.
$query->getQuery()->limit = 0;
$query->getQuery()->offset = 0;
Owner
|
Thanks for this PR, I just encountered the same issue. Will also look in the package as this might be a bug. |
Author
|
sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove limit and offset before executing aggregate (count) query