Skip to content

Add improvement of performance in SpecValidation on validateSettings #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yonaskolb merged 1 commit into from
Dec 29, 2024
Merged

Add improvement of performance in SpecValidation on validateSettings #1522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions Sources/ProjectSpec/SpecValidation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,27 +17,30 @@ extension Project {
errors.append(.invalidSettingsGroup(group))
}
}

for config in settings.configSettings.keys {
if !configs.contains(where: { $0.name.lowercased().contains(config.lowercased()) }) {
if !options.disabledValidations.contains(.missingConfigs) {
errors.append(.invalidBuildSettingConfig(config))
}
if !configs.contains(where: { $0.name.lowercased().contains(config.lowercased()) }),
!options.disabledValidations.contains(.missingConfigs) {
errors.append(.invalidBuildSettingConfig(config))
}
}

if settings.buildSettings.count == configs.count {
var allConfigs = true
for buildSetting in settings.buildSettings.keys {
outerLoop: for buildSetting in settings.buildSettings.keys {
var isConfig = false
for config in configs {
if config.name.lowercased().contains(buildSetting.lowercased()) {
isConfig = true
break
}
}
if !isConfig {
allConfigs = false
break outerLoop
}
}

if allConfigs {
errors.append(.invalidPerConfigSettings)
}
Expand Down