Skip to content

Commit d35d164

Browse files
IgorMinarjasonaden
authored andcommitted
test(ivy): add fixme to a failing testbed test (angular#27278)
PR Close angular#27278
1 parent f7ba4b2 commit d35d164

File tree

3 files changed

+21
-18
lines changed

3 files changed

+21
-18
lines changed

packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ jasmine_node_test(
3131
":test_lib",
3232
"//packages/platform-server",
3333
"//packages/platform-server/testing",
34+
"//packages/private/testing",
3435
"//tools/testing:node",
3536
],
3637
)

packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/app_spec.ts

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import {Component, INJECTOR, Injectable, NgModule} from '@angular/core';
1010
import {TestBed} from '@angular/core/testing';
1111
import {renderModuleFactory} from '@angular/platform-server';
12+
import {fixmeIvy} from '@angular/private/testing';
1213
import {BasicAppModuleNgFactory} from 'app_built/src/basic.ngfactory';
1314
import {DepAppModuleNgFactory} from 'app_built/src/dep.ngfactory';
1415
import {HierarchyAppModuleNgFactory} from 'app_built/src/hierarchy.ngfactory';
@@ -167,20 +168,21 @@ describe('ngInjectableDef Bazel Integration', () => {
167168
expect(TestBed.get(INJECTOR).get('foo')).toEqual('bar');
168169
});
169170

170-
it('Component injector understands requests for INJECTABLE', () => {
171-
@Component({
172-
selector: 'test-cmp',
173-
template: 'test',
174-
providers: [{provide: 'foo', useValue: 'bar'}],
175-
})
176-
class TestCmp {
177-
}
178-
179-
TestBed.configureTestingModule({
180-
declarations: [TestCmp],
181-
});
182-
183-
const fixture = TestBed.createComponent(TestCmp);
184-
expect(fixture.componentRef.injector.get(INJECTOR).get('foo')).toEqual('bar');
185-
});
171+
fixmeIvy('FW-646: Directive providers don\'t support primitive types') &&
172+
it('Component injector understands requests for INJECTABLE', () => {
173+
@Component({
174+
selector: 'test-cmp',
175+
template: 'test',
176+
providers: [{provide: 'foo', useValue: 'bar'}],
177+
})
178+
class TestCmp {
179+
}
180+
181+
TestBed.configureTestingModule({
182+
declarations: [TestCmp],
183+
});
184+
185+
const fixture = TestBed.createComponent(TestCmp);
186+
expect(fixture.componentRef.injector.get(INJECTOR).get('foo')).toEqual('bar');
187+
});
186188
});

packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ ts_library(
1111
],
1212
),
1313
tags = [
14-
"ivy-only",
1514
"fixme-ivy-aot",
15+
"ivy-only",
1616
],
1717
deps = [
1818
"//packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app",
@@ -25,8 +25,8 @@ jasmine_node_test(
2525
name = "test",
2626
bootstrap = ["angular/tools/testing/init_node_spec.js"],
2727
tags = [
28-
"ivy-only",
2928
"fixme-ivy-aot",
29+
"ivy-only",
3030
],
3131
deps = [
3232
":test_lib",

0 commit comments

Comments
 (0)