Skip to content

Commit 7e0e3f1

Browse files
committed
fix(sunricher): address Copilot review on SR-ZG9032A-PIR
- Rename pwm_output_percentage → pwm_output_level and drop "%" unit. Per device documentation, value is raw 0-254 (where 254 = 100%); the manufacturer's BLE app exposes this attribute as a raw level too. - Rename linearity_error_ratio_lux → linearity_error_ratio. Value is a dimensionless coefficient (per-mille, default 1000 = 100%) applied to lux measurement; the _lux suffix misled toward a unit.
1 parent f2fc747 commit 7e0e3f1

1 file changed

Lines changed: 7 additions & 8 deletions

File tree

zhaquirks/sunricher/sr_zg9032a_pir.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@ class AttributeDefs(Basic.AttributeDefs):
2828
type=t.uint8_t,
2929
manufacturer_code=SUNRICHER_MANUFACTURER_CODE,
3030
)
31-
pwm_output_percentage: Final = ZCLAttributeDef(
31+
pwm_output_level: Final = ZCLAttributeDef(
3232
id=0x8909,
3333
type=t.uint8_t,
3434
manufacturer_code=SUNRICHER_MANUFACTURER_CODE,
3535
)
36-
linearity_error_ratio_lux: Final = ZCLAttributeDef(
36+
linearity_error_ratio: Final = ZCLAttributeDef(
3737
id=0x890D,
3838
type=t.uint16_t,
3939
manufacturer_code=SUNRICHER_MANUFACTURER_CODE,
@@ -66,22 +66,21 @@ class AttributeDefs(Basic.AttributeDefs):
6666
fallback_name="Motion sensor sensitivity",
6767
)
6868
.number(
69-
SunricherPIRBasicCluster.AttributeDefs.pwm_output_percentage.name,
69+
SunricherPIRBasicCluster.AttributeDefs.pwm_output_level.name,
7070
SunricherPIRBasicCluster.cluster_id,
7171
min_value=0,
7272
max_value=254,
73-
unit="%",
7473
entity_type=EntityType.CONFIG,
75-
translation_key="pwm_output_percentage",
76-
fallback_name="PWM output percentage",
74+
translation_key="pwm_output_level",
75+
fallback_name="PWM output level",
7776
)
7877
.number(
79-
SunricherPIRBasicCluster.AttributeDefs.linearity_error_ratio_lux.name,
78+
SunricherPIRBasicCluster.AttributeDefs.linearity_error_ratio.name,
8079
SunricherPIRBasicCluster.cluster_id,
8180
min_value=100,
8281
max_value=10000,
8382
entity_type=EntityType.CONFIG,
84-
translation_key="linearity_error_ratio_lux",
83+
translation_key="linearity_error_ratio",
8584
fallback_name="Linearity error ratio coefficient",
8685
)
8786
.add_to_registry()

0 commit comments

Comments
 (0)