feat(store): yank block producer service#2142
Merged
Merged
Conversation
Mirko-von-Leipzig
added
store
Mirko-von-Leipzig
force-pushed
the
mirko/yank-bp
branch
from
bd4e2d3 to
96db994
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/yank-store-bp
branch
from
9c73f1a to
88a3080
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/yank-bp
branch
from
96db994 to
a120482
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/yank-store-bp
branch
from
88a3080 to
7904193
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/yank-store-bp
branch
from
7904193 to
a98665b
Compare
SantiagoPittella
approved these changes
May 27, 2026
sergerad
reviewed
May 28, 2026
sergerad
requested changes
May 28, 2026
Collaborator
sergerad
left a comment
sergerad
left a comment
There was a problem hiding this comment.
LGTM just should replace the clone with into_parts I think.
| proposed_batches: stats.proposed_batches, | ||
| proven_batches: stats.proven_batches, | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Should these be From<> impls?
Collaborator
Author
There was a problem hiding this comment.
Ah actually, that's not really possible unless we import either block producer in the proto crate, or vice versa. Neither of those is appealing so I'm going to leave these in place.
Once we switch to using the gRPC framework these will become encode/decode functions in any case.
Mirko-von-Leipzig
force-pushed
the
mirko/yank-store-bp
branch
from
a98665b to
1889a47
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/yank-store-bp
branch
from
0cc726e to
b6efd00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the store's block-producer gRPC service. This leaves the store's RPC service as the only remaining item to yank.
The block-producer gets a store
Stateand directly accesses the previous gRPC methods instead. This also removes the store/block-producer desync opportunity.I also want to move the block proving to the block-producer, and have store only expose
Statewith no extra tasks attached. However, this will only really be possible after the last gRPC service is removed, so for now I've elected to minimize the diff instead of moving things across.Stacks on #2140.