Using buttons with multiple encoders

[guibom]

I was having issues using multiple encoder objects with their buttons.

Only the first object that runs the service function would update their value.
The actual encoder part of the object runs fine and keeps their individual positions.

My solution (not sure if ideal) was to remove the static variables keyDownTicks, doubleClickTicks, lastButtonCheck from the service function and move them to the header file.

[samkusnetz]

guibom, where did you move them to, exactly? i'm trying the same solution and still cannot get my second and third encoders' buttons to register.

[Ardego]

Hi,
I just stumbled over the same issue, want to use two encoders with buttons,
Number 1 works flawlessly, but number two ignores all button activity for some reason.
Grateful for any help into the right direction.

Thanks!

[mr-miky]

has a fucking bugs in the service () !!

technically the reading of the second button is not executed because occurs during the period of debouncing of the previous button.
The problem arises because keyDownTicks, doubleClickTicks, lastButtonCheck are static.
I solved by making sure that every instance of "ClickEncoder" have their keyDownTicks, doubleClickTicks, lastButtonCheck.

The changes are small to do ....

[mr-miky]

in clickEncoder.h add keyDownTicks, doubleClickTicks, lastButtonCheck:

#ifndef WITHOUT_BUTTON
volatile Button button;
bool doubleClickEnabled;
bool accelerationEnabled;
uint16_t keyDownTicks;
uint8_t doubleClickTicks;
unsigned long lastButtonCheck;
#endif

in ClickEncoder.cpp initialize keyDownTicks, doubleClickTicks, lastButtonCheck

if (digitalRead(pinA) == pinsActive) {
last = 3;
}

if (digitalRead(pinB) == pinsActive) {
last ^=1;
}

#ifndef WITHOUT_BUTTON
keyDownTicks = 0;
doubleClickTicks = 0;
lastButtonCheck = 0;
#endif

and comment out all 3 line with static declaration

// handle button
//
#ifndef WITHOUT_BUTTON
// static uint16_t keyDownTicks = 0;
// static uint8_t doubleClickTicks = 0;
// static unsigned long lastButtonCheck = 0;

[4noxx]

i try your code, but my second encoder will not run, i dont no why....

here is my code:

#include <TimerThree.h>
#include <Keyboard.h>
#include <ClickEncoder.h>
#include <TimerOne.h>

ClickEncoder *encoder01;
ClickEncoder *encoder02;

int16_t last01, value01;
int16_t last02, value02;

void timerIsr01()
{
encoder01->service();
}

void timerIsr02()
{
encoder02->service();
}

void setup()
{
Serial.begin(9600);
encoder01 = new ClickEncoder(A1, A0, A2, 4); // Encoder Pin an A0 und A1, Button Pin an A2; Restlichen Pins direkt an GND ### 4 = stepsPerNotch
encoder02 = new ClickEncoder(A4, A3, A5, 4); // Encoder Pin an A0 und A1, Button Pin an A2; Restlichen Pins direkt an GND ### 4 = stepsPerNotch

Timer1.initialize(1000);
Timer1.attachInterrupt(timerIsr01);

Timer3.initialize(1000);
Timer3.attachInterrupt(timerIsr02);

last01 = -1;
last02 = -1;
}

void loop()
{
value01 += encoder01->getValue();

if (value01 != last01)
{
if (value01 < last01)
{
Serial.print(value01);
Serial.print("\n01: Right \n");

}
if (value01 > last01)
{
  Serial.print(value01);
  Serial.print("\n01: Left \n");

}
last01 = value01;

}

ClickEncoder::Button b = encoder01->getButton();
if (b != ClickEncoder::Open)
{
switch (b)
{
case ClickEncoder::Pressed:
Serial.print("01: Pressed \n");
break;
case ClickEncoder::Held:
Serial.print("01: Held \n");
break;
case ClickEncoder::Released:
Serial.print("01: Released \n");
break;
case ClickEncoder::Clicked:
Serial.print("01: Clicked \n");
break;
case ClickEncoder::DoubleClicked:
Serial.print("01: DoubleClicked \n");
break;
}

// E N C O D E R 2

value02 += encoder02->getValue();

if (value02 != last02)
{
if (value02 < last02)
{
Serial.print(value02);
Serial.print("\n01: Right \n");

}
if (value02 > last02)
{
  Serial.print(value02);
  Serial.print("\n02: Left \n");

}
last02 = value02;

}

ClickEncoder::Button c = encoder02->getButton();
if (c != ClickEncoder::Open)
{
switch (c)
{
case ClickEncoder::Pressed:
Serial.print("02: Pressed \n");
break;
case ClickEncoder::Held:
Serial.print("02: Held \n");
break;
case ClickEncoder::Released:
Serial.print("02: Released \n");
break;
case ClickEncoder::Clicked:
Serial.print("02: Clicked \n");
break;
case ClickEncoder::DoubleClicked:
Serial.print("02: DoubleClicked \n");
break;
}
}

}
}

[mr-miky]

I suspect the problem is that you use 2 timers.
It makes no sense, so try:

void timerIsr01()
{
encoder01->service();
encoder02->service();
}

and remove the code for timer3 ( initialization etc etc )

[4noxx]

i change the code, but it will not work
encoder 1 works fine, encoder 2 do nothing

my ClickEncoder.h:
http://pastebin.com/JYVd1jVt

my ClickEncoder.cpp:
http://pastebin.com/mybzDgDd

myCode:

#include <Keyboard.h>
#include <ClickEncoder.h>
#include <TimerOne.h>

ClickEncoder *encoder01;
ClickEncoder *encoder02;

int16_t last01, value01;
int16_t last02, value02;

void timerIsr01()
{
encoder01->service();
encoder02->service();
}

void setup()
{
Serial.begin(9600);
encoder01 = new ClickEncoder(A1, A0, A2, 4); // Encoder Pin an A0 und A1, Button Pin an A2; Restlichen Pins direkt an GND ### 4 = stepsPerNotch
encoder02 = new ClickEncoder(A4, A3, A5, 4); // Encoder Pin an A0 und A1, Button Pin an A2; Restlichen Pins direkt an GND ### 4 = stepsPerNotch

Timer1.initialize(1000);
Timer1.attachInterrupt(timerIsr01);

last01 = -1;
last02 = -1;
}

void loop()
{
value01 += encoder01->getValue();

if (value01 != last01)
{
if (value01 < last01)
{
Serial.print(value01);
Serial.print("\n01: Right \n");

}
if (value01 > last01)
{
  Serial.print(value01);
  Serial.print("\n01: Left \n");

}
last01 = value01;

}

ClickEncoder::Button b = encoder01->getButton();
if (b != ClickEncoder::Open)
{
switch (b)
{
case ClickEncoder::Pressed:
Serial.print("01: Pressed \n");
break;
case ClickEncoder::Held:
Serial.print("01: Held \n");
break;
case ClickEncoder::Released:
Serial.print("01: Released \n");
break;
case ClickEncoder::Clicked:
Serial.print("01: Clicked \n");
break;
case ClickEncoder::DoubleClicked:
Serial.print("01: DoubleClicked \n");
break;
}

// E N C O D E R 2

value02 += encoder02->getValue();

if (value02 != last02)
{
if (value02 < last02)
{
Serial.print(value02);
Serial.print("\n01: Right \n");

}
if (value02 > last02)
{
  Serial.print(value02);
  Serial.print("\n02: Left \n");

}
last02 = value02;

}

ClickEncoder::Button c = encoder02->getButton();
if (c != ClickEncoder::Open)
{
switch (c)
{
case ClickEncoder::Pressed:
Serial.print("02: Pressed \n");
break;
case ClickEncoder::Held:
Serial.print("02: Held \n");
break;
case ClickEncoder::Released:
Serial.print("02: Released \n");
break;
case ClickEncoder::Clicked:
Serial.print("02: Clicked \n");
break;
case ClickEncoder::DoubleClicked:
Serial.print("02: DoubleClicked \n");
break;
}
}

}
}

[mr-miky]

try to swap encoder service

void timerIsr01()
{
encoder02->service();
encoder01->service();
}

in my case, when I did so, the push button 2 worked but not more than the 1

can you confirm ?

[4noxx]

no, if i change to
void timerIsr01()
{
encoder02->service();
encoder01->service();
}
also encoder 1 works, encoder 2 not

[mr-miky]

try to swap connections of encoders.
making the exchange you can understand if the button of encoder 2 really works or if the input of Arduino used for the push button 2 is faulty.

I can manage 6 multiplexed encoders ....

[4noxx]

Both Encoder works. Change to other Pins dont works, i mean only one works.

Can you post your *.h and *.cpp and your arduino code? Pastebin?

[4noxx]

i ve now a solution.
i copy the complete libary to a second folder Clickencoder2
and change all Clickencoder to Clickencoder2 (in *.h and *.cpp)
in my scetch i use this
ClickEncoder *encoder;
ClickEncoder2 *encoder2;

works

[mr-miky]

But ... i've found the reason why encoder2 don't work !
Your code is syntactically correct but wrong.
I copied and pasted your code on a C ++ editor, and then I did indent reformat.

your code
http://pastebin.com/zR5UTjxU

my fixed & tested code
http://pastebin.com/KaUUF7ZC

see the higligted difference ...

[4noxx]

hmm. thx. but i see no diffence ?!?!?!

[mr-miky]

wow ... no difference ?
in your code all the instructions for the second encoder are performed only when the button of the first encoder is not open .....

The only difference between the two codes is where are located 2 braces.

I do not remember if the arduino IDE has highlighting matching bracket. Moving the cursor after an open bracket it highlight the corresponding closing bracket