Skip to content

Remove support for delayed inline scripts #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joemcgill merged 7 commits into from
Jun 22, 2023
Merged

Remove support for delayed inline scripts #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
34a725d
Update unit tests for removal of inline script support
joemcgill Jun 20, 2023
1c91094
Remove support for delayed inline scripts
joemcgill Jun 20, 2023
967a704
Update has_only_delayed_dependents to return false if inline after sc…
10upsimon Jun 21, 2023
c6fc771
Remove delayed-inline-script-loader.js and references
joemcgill Jun 21, 2023
a4eeb98
Consolidate logic for determining eligible loading strategies
joemcgill Jun 21, 2023
12969ea
Cast return values for has_inline_script to bool
joemcgill Jun 22, 2023
16ffb03
Add additional unit test cases
joemcgill Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,6 @@ module.exports = function(grunt) {
[ WORKING_DIR + 'wp-includes/js/wp-auth-check.js' ]: [ './src/js/_enqueues/lib/auth-check.js' ],
[ WORKING_DIR + 'wp-includes/js/wp-backbone.js' ]: [ './src/js/_enqueues/wp/backbone.js' ],
[ WORKING_DIR + 'wp-includes/js/wp-custom-header.js' ]: [ './src/js/_enqueues/wp/custom-header.js' ],
[ WORKING_DIR + 'wp-includes/js/wp-delayed-inline-script-loader.js' ]: [ './src/js/_enqueues/lib/delayed-inline-script-loader.js' ],
[ WORKING_DIR + 'wp-includes/js/wp-embed-template.js' ]: [ './src/js/_enqueues/lib/embed-template.js' ],
[ WORKING_DIR + 'wp-includes/js/wp-embed.js' ]: [ './src/js/_enqueues/wp/embed.js' ],
[ WORKING_DIR + 'wp-includes/js/wp-emoji-loader.js' ]: [ './src/js/_enqueues/lib/emoji-loader.js' ],
Expand Down Expand Up @@ -924,7 +923,6 @@ module.exports = function(grunt) {
'src/wp-includes/js/wp-auth-check.js': 'src/js/_enqueues/lib/auth-check.js',
'src/wp-includes/js/wp-backbone.js': 'src/js/_enqueues/wp/backbone.js',
'src/wp-includes/js/wp-custom-header.js': 'src/js/_enqueues/wp/custom-header.js',
'src/wp-includes/js/wp-delayed-inline-script-loader.js': 'src/js/_enqueues/lib/delayed-inline-script-loader.js',
'src/wp-includes/js/wp-embed-template.js': 'src/js/_enqueues/lib/embed-template.js',
'src/wp-includes/js/wp-embed.js': 'src/js/_enqueues/wp/embed.js',
'src/wp-includes/js/wp-emoji-loader.js': 'src/js/_enqueues/lib/emoji-loader.js',
Expand Down
107 changes: 0 additions & 107 deletions src/js/_enqueues/lib/delayed-inline-script-loader.js
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions src/wp-includes/class-wp-dependencies.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,18 +126,6 @@ public function do_items( $handles = false, $group = false ) {
$handles = false === $handles ? $this->queue : (array) $handles;
$this->all_deps( $handles );

return $this->process_to_do_items( $group );
}

/**
* Processes the items marked for to do, and their dependencies.
*
* @since 6.3.0
*
* @param int|false $group Group level: level (int), no group (false).
* @return string[] Array of handles of items that have been processed.
*/
protected function process_to_do_items( $group ) {
foreach ( $this->to_do as $key => $handle ) {
if ( ! in_array( $handle, $this->done, true ) && isset( $this->registered[ $handle ] ) ) {
/*
Expand Down
Loading