Skip to content
This repository was archived by the owner on Oct 17, 2020. It is now read-only.

Clock countdown#5

Closed
GomezMimo wants to merge 27 commits into
masterfrom
clock
Closed

Clock countdown#5
GomezMimo wants to merge 27 commits into
masterfrom
clock

Conversation

@GomezMimo

Copy link
Copy Markdown
Collaborator

Clock Countdown

Shows a countdown for flutter event.

Staging link

https://huge-flutter-dev-qa.firebaseapp.com/clock

Screenshot image

image

@1Iv4N 1Iv4N left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the 320px breakpoint, it looks like is broken.

Comment thread src/_assets/css/_clock.scss Outdated
}

.time-number {
animation: slide-in 0.8s;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove leading cero.

Comment thread src/_assets/css/_clock.scss Outdated
z-index: -1;

&--first {
animation-delay: 0s;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unit.

Comment thread src/_assets/css/_clock.scss Outdated
}

&--second {
animation-delay: 0.2s;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove leading cero. Please, review all definitions.

@@ -1,6 +1,6 @@
.showcase {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we editing showcase styles?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some styles that can be shared in the clock and showcase, that's why I took the opportunity to change it.

Comment thread src/_assets/css/_variables.scss Outdated
$flutter-color-dark-blue: #075b9a;
$flutter-color-fuchsia: #FF2B5B;
$flutter-color-light-blue: #E7F8FF;
$flutter-color-dark-blue: #232C33;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful! You're overriding an existing variable.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my bad, thanks.

Comment thread src/_assets/css/_clock.scss Outdated
}

&--thrid {
animation-delay: 0.4s;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove leading cero.

Comment thread src/_assets/css/_clock.scss Outdated
}

&--fourth {
animation-delay: 0.6s;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove leading cero.

Comment thread src/_assets/css/_clock.scss Outdated
.svg-animated {
animation-duration: 1.2s;
animation-fill-mode: both;
animation-timing-function: cubic-bezier(0.87, 1.15, 1, 0.99);

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove leading cero.

Comment thread src/_assets/css/_clock.scss Outdated
Comment on lines +204 to +206
@include media-breakpoint-up(md) {
display: none;
}

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is not necessary.

Comment thread src/_assets/css/_clock.scss Outdated
Comment on lines +232 to +234
@include media-breakpoint-up(lg) {
display: none;
}

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is not necessary.

@GomezMimo GomezMimo requested a review from 1Iv4N October 23, 2019 21:22
@1Iv4N

1Iv4N commented Nov 1, 2019

Copy link
Copy Markdown
Owner

@OmarGM2294 will create a new PR.

@1Iv4N 1Iv4N closed this Nov 1, 2019
@GomezMimo GomezMimo deleted the clock branch November 22, 2019 16:21
GomezMimo added a commit that referenced this pull request Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants