This repository was archived by the owner on Dec 19, 2023. It is now read-only.
Fix MITM (http -> https)#1
Merged
Merged
Conversation
|
Congratulations mufeedvh - your fix has been selected! 🎉 Thanks for being part of the community & helping secure the world's open source code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📊 Metadata *
Bounty URL: https://www.huntr.dev/bounties/1-npm-node-sfml
⚙️ Description *
The URL to import packages from was hardcoded to use the
httpversion of the domains:kcat.strangesoft.netwww.mega-nerd.comsfml.svn.sourceforge.net💻 Technical Description *
The fix just simply changes the
httpversion tohttpsto mitigate MITM attacks.🐛 Proof of Concept (PoC) *
sfmlis Node v8 Bindings for SFML, this package are vulnerable to Man in the Middle (MitM) attacks due to downloading resources over an insecure protocol.Without a secure connection, it is possible for an attacker to intercept this connection and alter the packages received. In serious cases, this may even lead to Remote Code Execution (RCE) on your host server.
Ref: https://www.huntr.dev/bounties/1-npm-node-sfml/
🔥 Proof of Fix (PoF) *
Changed all domains with SSL certificates to
httpsin theinstallfile.Although the domain
www.mega-nerd.comdoesn't have an SSL certificate making it not possible to use thehttpsversion of the domain.👍 User Acceptance Testing (UAT)
No breaking changes.