Skip to content

Rofi spread#13

Open
anton-seaice wants to merge 19 commits intocmeps1.1.35-xfrom
rofi_spread
Open

Rofi spread#13
anton-seaice wants to merge 19 commits intocmeps1.1.35-xfrom
rofi_spread

Conversation

@anton-seaice
Copy link
Copy Markdown
Collaborator

@anton-seaice anton-seaice commented Mar 1, 2026

This change allows for spreading of the iceberg melt field according to a climatological pattern.

A new configuration parameter is added, rof2ocn_ice_spread - which is the filename for a netcdf file with a 12-monthly climatological spreading pattern. If this parameter is not set - there is no change to existing behaviour (see repro test)

When a file is provided, the incoming Forr_rofi field is spread according to the pattern supplied in the climatology of spreading.

e.g., for January:

image

and for June:

image

Water volume is maintained between that coming from drof and ficeberg in MOM:

image

See example OM3 100km configuration:

ACCESS-NRI/access-om3-configs@3169a38

@anton-seaice anton-seaice self-assigned this Mar 1, 2026
@anton-seaice anton-seaice marked this pull request as ready for review March 4, 2026 03:05
@anton-seaice
Copy link
Copy Markdown
Collaborator Author

mediator timestamps are a bit strange, hence the minor difference in mediator vs mom runoff plots:

image

@aekiss
Copy link
Copy Markdown

aekiss commented Mar 10, 2026

Thanks @anton-seaice - do you think this is ready for the next 25km IAF test run?

@anton-seaice
Copy link
Copy Markdown
Collaborator Author

Ready from my perspective.

  1. Do we want to seperate the impact of changing the land mask in the poles to support b-grid advection from this change ?
  2. Needs review and deployment - would take a few days at least

Comment thread mediator/med_io_mod.F90
Comment thread mediator/med_io_mod.F90 Outdated
@anton-seaice
Copy link
Copy Markdown
Collaborator Author

I did some cleanup, but have finished that for now

Copy link
Copy Markdown

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @anton-seaice. Sorry for taking so long to get to this.

My main worry is the lack of time interpolation and the resulting step changes in the pattern between months. But, as we've discussed, we probably can't address that here.

Comment thread mediator/med_io_mod.F90 Outdated
Comment thread mediator/med_phases_post_rof_mod.F90 Outdated
Comment thread mediator/med_phases_post_rof_mod.F90 Outdated
Comment thread mediator/med_phases_post_rof_mod.F90 Outdated
Comment thread mediator/med_phases_post_rof_mod.F90 Outdated
Comment thread mediator/med_io_mod.F90 Outdated
Comment thread mediator/med_io_mod.F90 Outdated
Comment thread mediator/med_io_mod.F90 Outdated
Comment thread mediator/med_io_mod.F90 Outdated
Comment thread mediator/med_io_mod.F90 Outdated
Co-authored-by: Dougie Squire <dougie.squire@anu.edu.au>
Comment thread mediator/med_io_mod.F90 Outdated
Comment thread mediator/med_io_mod.F90 Outdated
Comment thread mediator/med_io_mod.F90 Outdated
anton-seaice and others added 3 commits April 20, 2026 12:03
@anton-seaice
Copy link
Copy Markdown
Collaborator Author

I think I got all the comments @dougiesquire - should be good to go

@anton-seaice
Copy link
Copy Markdown
Collaborator Author

Example output in /g/data/tm70/as2285/payu/om3-rofi-spread/dev-MC_100km_jra_ryf/archive/output000

Copy link
Copy Markdown

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anton-seaice - just this comment remaining

@dougiesquire
Copy link
Copy Markdown

Do we want to abort or just not apply the normalisation when the sum is zero? What if one wanted to spread one hemi and not the other? Am I overthinking this?

@anton-seaice
Copy link
Copy Markdown
Collaborator Author

Oh yeah, will be a problem for panant

@anton-seaice
Copy link
Copy Markdown
Collaborator Author

Possibly good now @dougiesquire

Comment thread mediator/med_phases_post_rof_mod.F90 Outdated
Comment thread mediator/med_phases_post_rof_mod.F90 Outdated
Comment on lines +571 to +575
if (lats(i) < 0.0_r8 .and. spread_rofi_sh) then
rof2ocn_spread(i,month) = rof2ocn_spread(i,month) / global_sum(1)
else if ( spread_rofi_nh ) then
rof2ocn_spread(i,month) = rof2ocn_spread(i,month) / global_sum(2)
end if
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will enter the else for SH cells if spread_rofi_sh=.false. and spread_rofi_nh=.true., so SH cells will get incorrectly divided by the NH sum (I don't think the incorrect rof2ocn_spread would actually be used in this case but still good to correct to avoid confusion).

Suggested change
if (lats(i) < 0.0_r8 .and. spread_rofi_sh) then
rof2ocn_spread(i,month) = rof2ocn_spread(i,month) / global_sum(1)
else if ( spread_rofi_nh ) then
rof2ocn_spread(i,month) = rof2ocn_spread(i,month) / global_sum(2)
end if
if (lats(i) < 0.0_r8 .and. spread_rofi_sh) then
rof2ocn_spread(i,month) = rof2ocn_spread(i,month) / global_sum(1)
else if (lats(i) >= 0.0_r8 .and. spread_rofi_nh) then
rof2ocn_spread(i,month) = rof2ocn_spread(i,month) / global_sum(2)
end if

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed now

Comment thread mediator/med_phases_post_rof_mod.F90 Outdated
Comment thread mediator/med_phases_post_rof_mod.F90 Outdated
Comment thread mediator/med_phases_post_rof_mod.F90 Outdated
anton-seaice and others added 4 commits April 28, 2026 15:13
Co-authored-by: Dougie Squire <dougie.squire@anu.edu.au>
Co-authored-by: Dougie Squire <dougie.squire@anu.edu.au>
Comment thread mediator/med_phases_post_rof_mod.F90 Outdated
Comment thread mediator/med_phases_post_rof_mod.F90 Outdated
Co-authored-by: Dougie Squire <dougie.squire@anu.edu.au>
Copy link
Copy Markdown

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anton-seaice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants